Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GooglePathHandler for GCS input and output #40

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

XDynames
Copy link

@XDynames XDynames commented Sep 8, 2020

Support for path handling on google cloud storage file systems, enabling remote checkpointing, logging and resuming

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2020
@XDynames
Copy link
Author

XDynames commented Sep 8, 2020

I think something is wrong with your CI for cpu testing, isort fails with the following message:

isort your imports, so you don't have to.

                  VERSION 5.5.1


Nothing to do: no files or paths have have been passed in!

Try one of the following:

  'isort .' - sort all Python files, starting from the current directory, recursively.
  'isort . --interactive` - Do the same, but ask before making any changes.
  'isort . --check --diff` - Check to see if imports are correctly sorted within this project.
  'isort --help` - In-depth information about isort's available command-line options.

Visit https://pycqa.github.io/isort/ for complete information about how to use isort.

Error: arguments passed in without any paths or content.

Exited with code exit status 1

The command being called completes fine locally isort -c -sp .

ppwwyyxx and others added 3 commits September 8, 2020 17:52
Reviewed By: alexander-kirillov

Differential Revision: D23588432

fbshipit-source-id: 46f101544a99d776ffa0157dcababfb212dcf212
…arch#41)

Summary:
It's better for users to see what objects are in registry, so I implemented __repr__ for Registry.

Please kindly review :)

Pull Request resolved: facebookresearch#41

Reviewed By: rbgirshick

Differential Revision: D23620800

Pulled By: ppwwyyxx

fbshipit-source-id: 5e01424ec6da64323fd47fd6e9fc92fa9aca07bd
Differential Revision: D23640872

fbshipit-source-id: ff78e86bb9d8fae87fc8d07fd267c8cc512862df
@Jennifer-Rigdon
Copy link

The isort step has now been removed altogether: b9b724c

@oeclint
Copy link

oeclint commented Mar 28, 2021

any updates, this would be pretty neat

@XDynames
Copy link
Author

I've been using it in my own projects in detectron 2 for 8 months now
Doesn't seem to be a priority for fvcore to have this support merged in
I have hosted it separately in another repository of you want to use it https://github.com/XDynames/google_cloud_for_fvcore_detectron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants