Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IGNORE] 3526: numpy 2 hacks #3788

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[IGNORE] 3526: numpy 2 hacks #3788

wants to merge 6 commits into from

Conversation

asadoughi
Copy link
Contributor

@asadoughi asadoughi commented Aug 23, 2024 •
edited
Loading

ran with numpy==2.1.0 on OS X

  • need to understand why SWIG is not converting np.float32 as float * as it was before
  • numpy/numpy/18058 mentions we should be using show_config() or perhaps show_runtime() instead of the internal api

@asadoughi
3526: numpy 2 hacks
6d0da99 
* need to fix SWIG to understand why its not auto-converting np.float32 as float * as it was before
* numpy/numpy/18058 mentions we should be using show_config() or perhaps show_runtime() instead of the internal api
@asadoughi asadoughi changed the title 3526: numpy 2 hacks [IGNORE] 3526: numpy 2 hacks Aug 23, 2024
@asadoughi asadoughi force-pushed the numpy2_hack branch 2 times, most recently from 975b923 to 3b6e229 Compare August 23, 2024 15:14
@asadoughi
Copy link
Contributor Author

3 additional failures to debug

FAILED tests/test_contrib.py::TestClustering::test_ivf_train_2level - AssertionError: np.int64(55) not less than 51

FAILED tests/test_index_accuracy.py::OPQRelativeAccuracy::test_OIVFPQ - assert np.float64(0.971) >= np.float64(0.972)

PyTorch on arm64 SVE is not compatible with numpy 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed ignore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asadoughi @facebook-github-bot