test buckify #35
Closed
test buckify #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@shayne-fletcher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shayne-fletcher
pushed a commit
to shayne-fletcher/reindeer
that referenced
this pull request
Jan 23, 2024
Summary: adds a github actions smoke test for the 'buckify' command. fails on windows in the same way we have observed the buck2 setup reindeer step failing so is a minimal reproducer for that and thus am not running this test on windows while we work it out. Test Plan: Imported from GitHub, without a `Test Plan:` line. https://github.com/facebookincubator/reindeer/actions/runs/7616629909/job/20743842687 Differential Revision: D52968685 Pulled By: shayne-fletcher
shayne-fletcher
force-pushed
the
buckify-test
branch
from
b36a678 to
1d21017
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52968685 |
shayne-fletcher
pushed a commit
to shayne-fletcher/reindeer
that referenced
this pull request
Jan 23, 2024
Summary: adds a github actions smoke test for the 'buckify' command. fails on windows in the same way we have observed the buck2 setup reindeer step failing so is a minimal reproducer for that and thus am not running this test on windows while we work it out. Test Plan: Imported from GitHub, without a `Test Plan:` line. https://github.com/facebookincubator/reindeer/actions/runs/7616629909/job/20743842687 Differential Revision: D52968685 Pulled By: shayne-fletcher
shayne-fletcher
force-pushed
the
buckify-test
branch
from
1d21017 to
119cf2e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52968685 |
Summary: adds a github actions smoke test for the 'buckify' command. updated to make use of the example project for this. Test Plan: Imported from GitHub, without a `Test Plan:` line. https://github.com/facebookincubator/reindeer/actions/runs/7620862356/job/20756295189 Differential Revision: D52968685 Pulled By: shayne-fletcher
shayne-fletcher
force-pushed
the
buckify-test
branch
from
119cf2e to
3c7cb8d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52968685 |
shayne-fletcher
pushed a commit
to shayne-fletcher/reindeer
that referenced
this pull request
Jan 23, 2024
Summary: adds a github actions smoke test for the 'buckify' command. updated to make use of the example project for this. Test Plan: Imported from GitHub, without a `Test Plan:` line. https://github.com/facebookincubator/reindeer/actions/runs/7620862356/job/20756295189 Differential Revision: D52968685 Pulled By: shayne-fletcher
|
@shayne-fletcher merged this pull request in 2e3b3c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a smoke test