-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Augment nimble_dump streams subcommand to include InMap stream indicator #130
Closed
chongfeng-hu
wants to merge
4
commits into
facebookincubator:main
from
chongfeng-hu:export-D67996331
Closed
Augment nimble_dump streams subcommand to include InMap stream indicator #130
chongfeng-hu
wants to merge
4
commits into
facebookincubator:main
from
chongfeng-hu:export-D67996331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Jan 9, 2025
This pull request was exported from Phabricator. Differential Revision: D67996331 |
chongfeng-hu
force-pushed
the
export-D67996331
branch
from
January 10, 2025 01:47
20ee811
to
fdade2f
Compare
chongfeng-hu
pushed a commit
to chongfeng-hu/nimble
that referenced
this pull request
Jan 10, 2025
…tor (facebookincubator#130) Summary: Add a new `--inmap_stream` option to the `streams` subcommand. When set, the output includes a new column, which indicates if each stream is an InMap stream for a FlatMap, or not. Differential Revision: D67996331
This pull request was exported from Phabricator. Differential Revision: D67996331 |
chongfeng-hu
force-pushed
the
export-D67996331
branch
from
January 10, 2025 18:41
fdade2f
to
ebd399d
Compare
chongfeng-hu
pushed a commit
to chongfeng-hu/nimble
that referenced
this pull request
Jan 10, 2025
…tor (facebookincubator#130) Summary: Add a new `--inmap_stream` option to the `streams` subcommand. When set, the output includes a new column, which indicates if each stream is an InMap stream for a FlatMap, or not. Reviewed By: helfman Differential Revision: D67996331
This pull request was exported from Phabricator. Differential Revision: D67996331 |
…ator#125) Summary: This new API will unlock use cases such as enumerating all optional sections in the Nimble file. It will also empower `nimble_dump` to be able to provide relevant information about the optional sections. Reviewed By: helfman Differential Revision: D67949242
…facebookincubator#126) Summary: These 2 new APIs will allow clients to get insights into stripes and stripe groups metadata, e.g., offset, size, etc. This information can be useful in use cases like `nimble_dump` where we want to know the sizes of these sections in the Nimble file. Reviewed By: helfman Differential Revision: D67957498
…by size (facebookincubator#129) Summary: This change augments `nimble_dump`'s `info` subcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes. Reviewed By: helfman Differential Revision: D67958989
…tor (facebookincubator#130) Summary: Add a new `--inmap_stream` option to the `streams` subcommand. When set, the output includes a new column, which indicates if each stream is an InMap stream for a FlatMap, or not. Reviewed By: helfman Differential Revision: D67996331
chongfeng-hu
force-pushed
the
export-D67996331
branch
from
January 10, 2025 19:43
ebd399d
to
07fcc45
Compare
This pull request was exported from Phabricator. Differential Revision: D67996331 |
This pull request has been merged in e3344c6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add a new
--inmap_stream
option to thestreams
subcommand. When set, the output includes a new column, which indicates if each stream is an InMap stream for a FlatMap, or not.Differential Revision: D67996331