Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment nimble_dump streams subcommand to include InMap stream indicator #130

Closed

Conversation

chongfeng-hu
Copy link

Summary: Add a new --inmap_stream option to the streams subcommand. When set, the output includes a new column, which indicates if each stream is an InMap stream for a FlatMap, or not.

Differential Revision: D67996331

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 9, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996331

chongfeng-hu pushed a commit to chongfeng-hu/nimble that referenced this pull request Jan 10, 2025
…tor (facebookincubator#130)

Summary:

Add a new `--inmap_stream` option to the `streams` subcommand. When set, the output includes a new column, which indicates if each stream is an InMap stream for a FlatMap, or not.

Differential Revision: D67996331
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996331

chongfeng-hu pushed a commit to chongfeng-hu/nimble that referenced this pull request Jan 10, 2025
…tor (facebookincubator#130)

Summary:

Add a new `--inmap_stream` option to the `streams` subcommand. When set, the output includes a new column, which indicates if each stream is an InMap stream for a FlatMap, or not.

Reviewed By: helfman

Differential Revision: D67996331
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996331

Chongfeng Hu added 4 commits January 10, 2025 11:43
…ator#125)

Summary:

This new API will unlock use cases such as enumerating all optional sections in the Nimble file. It will also empower `nimble_dump` to be able to provide relevant information about the optional sections.

Reviewed By: helfman

Differential Revision: D67949242
…facebookincubator#126)

Summary:

These 2 new APIs will allow clients to get insights into stripes and stripe groups metadata, e.g., offset, size, etc.

This information can be useful in use cases like `nimble_dump` where we want to know the sizes of these sections in the Nimble file.

Reviewed By: helfman

Differential Revision: D67957498
…by size (facebookincubator#129)

Summary:

This change augments `nimble_dump`'s `info` subcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes.

Reviewed By: helfman

Differential Revision: D67958989
…tor (facebookincubator#130)

Summary:

Add a new `--inmap_stream` option to the `streams` subcommand. When set, the output includes a new column, which indicates if each stream is an InMap stream for a FlatMap, or not.

Reviewed By: helfman

Differential Revision: D67996331
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996331

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e3344c6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants