Augment nimble_dump info subcommand by listing all metadata sections by size #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67958989 |
chongfeng-hu
pushed a commit
to chongfeng-hu/nimble
that referenced
this pull request
Jan 9, 2025
…by size (facebookincubator#129) Summary: This change augments `nimble_dump`'s `info` subcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes. Differential Revision: D67958989
chongfeng-hu
force-pushed
the
export-D67958989
branch
from
d4782a5 to
acf7e29
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67958989 |
chongfeng-hu
pushed a commit
to chongfeng-hu/nimble
that referenced
this pull request
Jan 10, 2025
…by size (facebookincubator#129) Summary: This change augments `nimble_dump`'s `info` subcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes. Differential Revision: D67958989
chongfeng-hu
force-pushed
the
export-D67958989
branch
from
acf7e29 to
6953ce4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67958989 |
chongfeng-hu
pushed a commit
to chongfeng-hu/nimble
that referenced
this pull request
Jan 10, 2025
…by size (facebookincubator#129) Summary: This change augments `nimble_dump`'s `info` subcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes. Differential Revision: D67958989
chongfeng-hu
pushed a commit
to chongfeng-hu/nimble
that referenced
this pull request
Jan 10, 2025
…by size (facebookincubator#129) Summary: This change augments `nimble_dump`'s `info` subcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes. Reviewed By: helfman Differential Revision: D67958989
chongfeng-hu
pushed a commit
to chongfeng-hu/nimble
that referenced
this pull request
Jan 10, 2025
…by size (facebookincubator#129) Summary: This change augments `nimble_dump`'s `info` subcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes. Reviewed By: helfman Differential Revision: D67958989
chongfeng-hu
force-pushed
the
export-D67958989
branch
from
6953ce4 to
a78b3c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67958989 |
added 3 commits
January 10, 2025 11:43
…ator#125) Summary: This new API will unlock use cases such as enumerating all optional sections in the Nimble file. It will also empower `nimble_dump` to be able to provide relevant information about the optional sections. Reviewed By: helfman Differential Revision: D67949242
…facebookincubator#126) Summary: These 2 new APIs will allow clients to get insights into stripes and stripe groups metadata, e.g., offset, size, etc. This information can be useful in use cases like `nimble_dump` where we want to know the sizes of these sections in the Nimble file. Reviewed By: helfman Differential Revision: D67957498
…by size (facebookincubator#129) Summary: This change augments `nimble_dump`'s `info` subcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes. Reviewed By: helfman Differential Revision: D67958989
chongfeng-hu
force-pushed
the
export-D67958989
branch
from
a78b3c4 to
99474ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67958989 |
|
This pull request has been merged in 5e6df68. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This change augments
nimble_dump'sinfosubcommand. With this change, we will list all metadata sections in the Nimble file, along with their respective sizes.Differential Revision: D67958989