DONOTSTRIP for kUnifexAsyncStackRootHolderList #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jesswong
approved these changes
Jan 9, 2025
jesswong
pushed a commit
to jesswong/libunifex
that referenced
this pull request
Jan 23, 2025
) Co-authored-by: Riley Berton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the
kUnifexAsyncStackRootHolderListsymbol is not stripped during the link phase so it can always be found in the symbol table.This does not protect against the
striptool which completely removes the .symtab. If you need to retain the pointer to the AsyncStackRootHolderList you will have to use the--keep-symbolflag if you are using thestriptool for smaller binaries.Note that
striptool will keep this symbol if you are sticking to "needed" symbols as it is marked as "used" but it won't survive under strip "all".