Create switch for disabling callback logging #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing reports of folks running into ODR issues when linking together TUs built with and without `NDEBUG` defined. The reason is that `unifex::inplace_stop_callback_base`'s size and layout depend on whether `NDEBUG` is defined, leading to incompatible ABIs between the two build modes. This change introduces a new preprocessor macro, `UNIFEX_LOG_DANGLING_STOP_CALLBACKS` that controls whether `inplace_stop_callback_base` knows a stringified typename of the deriving class and wheter `inplace_stop_source` uses that knowledge to log the names of dangling stop callbacks in its destructor. I've also updated `config.hpp.in` to retain existing behaviour: the default state for `UNIFEX_LOG_DANGLING_STOP_CALLBACKS` is on when `NDEBUG` is not defined an off when `NDEBUG` is defined. The defaults can be overridden.
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing reports of folks running into ODR issues when linking together TUs built with and without
NDEBUGdefined. The reason is thatunifex::inplace_stop_callback_base's size and layout depend on whetherNDEBUGis defined, leading to incompatible ABIs between the two build modes.This change introduces a new preprocessor macro,
UNIFEX_LOG_DANGLING_STOP_CALLBACKSthat controls whetherinplace_stop_callback_baseknows a stringified typename of the deriving class and whetherinplace_stop_sourceuses that knowledge to log the names of dangling stop callbacks in its destructor. I've also updatedconfig.hpp.into retain existing behaviour: the default state forUNIFEX_LOG_DANGLING_STOP_CALLBACKSis on whenNDEBUGis not defined and off whenNDEBUGis defined. The defaults can be overridden.There's also a drive-by fix for a TSAN error that pops up if you ever actually log dangling callbacks.