This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
master
.npm test
)npm run lint
) and passes Flow (npm run flow
)Please use the simple form below as a guideline for describing your pull request, and delete these instructions.
Thanks for contributing to Draft.js!
Summary
An issue occurs while using the toolbar inline plugin, an error is thrown in the method
getVisibleSelectionRect
because the value of the selection isnull
.The fix is to use
?.
on the existingif test
ofselection.rangeCount
to avoid this error.