Implement URL Accessors (host, hostname, username, password) for the URL class

[krishpranav]

#45030

Title:
Implement URL Accessors (host, hostname, username, password) for the URL class

Description:

Summary:

This PR addresses GitHub issue #45030 by implementing the missing URL accessors (host, hostname, username, and password) in the URL class for React Native. Prior to this change, accessing these properties would result in errors as they were not implemented. This update ensures compatibility with standard URL parsing and usage within the React Native ecosystem, especially for applications relying on web-based APIs that require access to these URL components.

Motivation:

These accessors are critical for extracting and working with specific URL components (e.g., domain, user credentials) in various networking scenarios. The lack of implementation was preventing the proper usage of these components in React Native, particularly when interacting with URLs that include authentication information or need parsing of domain-related properties.

Changelog:

• [INTERNAL] [ADDED]: Implemented host, hostname, username, and password accessors for the URL class in React Native.
• [INTERNAL] [CHANGED]: Updated the URL class to support retrieval of host, hostname, username, and password from the URL string, ensuring these properties return the correct values based on the URL structure.

Test Plan:

To ensure the functionality of the newly implemented accessors, I performed the following:

1. Unit Tests:

   • Ran the existing unit tests, which pass successfully.
   • Added tests to check for correct implementation of host, hostname, username, and password accessors in various scenarios.

2. Test Cases:

   • Validated various URL formats to ensure that all accessors return the expected values.
   • Verified that the new accessors handle both standard and edge-case URLs, including those with and without authentication information.

Here is a sample test case:

const testUrl = new URL('https://username:[email protected]:8080/path');
expect(testUrl.host).toBe('domain.com:8080');
expect(testUrl.hostname).toBe('domain.com');
expect(testUrl.username).toBe('username');
expect(testUrl.password).toBe('password');

All tests passed successfully, demonstrating that the changes are robust and do not introduce regressions.

---

Kindly let me know whether is there any further things needed to add on this pull request, I am a new contributor to this repo. I am looking forward to work on this repo and work on the untouched issues which needed fix. thanks :)

• Krisna Pranav

[facebook-github-bot]

Hi @krishpranav!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[krishpranav]

I've signed the cla

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[krishpranav]

Hi, any updates on it?

[javache]

This is a very commonly used class - I don't think we'd want to pay the cost upfront of parsing any URL passed in here.

[javache]

Why was this removed?

[javache]

Please revert this

[javache]

Which JSVM was this tested with?

[krishpranav]

node version: v20.18.1

[krishpranav]

@javache reverting the comments.

[krishpranav]

@javache I've reverted the comments. kindly check it.