Skip to content

Commit

Permalink
fix modal becoming unresponsive with PullToRefresh
Browse files Browse the repository at this point in the history
Summary:
## Changelog:

[iOS] [Fixed] - Fix app becoming unresponsive when RefreshControl is used inside of <Modal />

Fixes: #48579

This is a UIKit bug. Switching to `didMoveToSuperview` resolves it.

Reviewed By: cipolleschi

Differential Revision: D68025099

fbshipit-source-id: 5d5e730f002ca93748674655a8393b770dc11611

Co-authored-by: kkafar <[email protected]>
  • Loading branch information
2 people authored and facebook-github-bot committed Jan 13, 2025
1 parent cc4e4c7 commit 6cb2684
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,10 @@ - (void)_updateTitle

#pragma mark - Attaching & Detaching

- (void)didMoveToWindow
- (void)didMoveToSuperview
{
[super didMoveToWindow];
if (self.window) {
[super didMoveToSuperview];
if (self.superview) {
[self _attach];
} else {
[self _detach];
Expand Down

0 comments on commit 6cb2684

Please sign in to comment.