Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Gate test subtarget name behind cfg!(fbcode_build)
Summary: Code lens unit test debugging on an iOS On Demand seems to be broken. Looking at the generated buck test commands, it looks like it has to do with a mismatch between the target built tested and the "exact target" being provided. We generate something similar to this, injecting the `[dwarf-and-dsym]` subtarget to the target being built, but we don't inject the same in the pattern being matched: ``` buck2 test @//fbobjc/mode/buck2/ios-tests "fbsource//fbobjc/Apps/Internal/FocusPlayground/Models:TestFoo[dwarf-and-dsym]" -- --exact 'fbsource//fbobjc/Apps/Internal/FocusPlayground/Models:TestFoo - DummyTests/testFoo' --run-disabled ``` Previously, the test would match even if a subtarget was being built. See https://fb.workplace.com/groups/410668900045165/permalink/1256220735489973/ for workflows that are being impacted. This regressed in D66988950, written in opensource, so let's revert it internally to fix our workflows. Reviewed By: JakobDegen Differential Revision: D68593198 fbshipit-source-id: c9518260acc8fa4327cf2aaed232def4863577d3
- Loading branch information