Skip to content

Commit

Permalink
cells: Repro broken cell handling in file watcher
Browse files Browse the repository at this point in the history
Summary: Explanation in the diff. This seems pretty bad, I'm not going to fix it though, because it's kind of hard.

Reviewed By: stepancheg

Differential Revision: D55573384

fbshipit-source-id: b7b4483fcf34179bdeb18e33713ab7ce9422e857
  • Loading branch information
JakobDegen authored and facebook-github-bot committed Mar 31, 2024
1 parent d813851 commit 8eff0bd
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/buck2_file_watcher/src/watchman/interface.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ use crate::watchman::core::WatchmanEventType;
use crate::watchman::core::WatchmanKind;

struct WatchmanQueryProcessor {
// FIXME(JakobDegen): Storing these values statically is completely broken. See
// `tests/e2e/cells/test_file_watcher_resolution:test_changing_cell_location_bug` for a repro of
// a bug.
cells: CellResolver,
ignore_specs: HashMap<CellName, IgnoreSet>,
retain_dep_files_on_watchman_fresh_instance: bool,
Expand Down

0 comments on commit 8eff0bd

Please sign in to comment.