GHA failing due to plotly update remove failing lines #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Our GHA is failing due to a recent major update in plotly that is causing two tests which dig into plotly code to fail. This diff removes the failing lines to unblock gha Reviewed By: saitcakmak Differential Revision: D68918030
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68918030 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3291 +/- ##
========================================
Coverage 96.01% 96.01%
========================================
Files 514 518 +4
Lines 51955 52132 +177
========================================
+ Hits 49884 50055 +171
- Misses 2071 2077 +6 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 9bd4c16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our GHA is failing due to a recent major update in plotly that is causing two tests which dig into plotly code to fail.
This diff removes the failing lines to unblock gha
Reviewed By: saitcakmak
Differential Revision: D68918030