Move generation_strategy to a dedicated folder #3287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68720587 |
ItsMrLin
force-pushed
the
export-D68720587
branch
from
e33721f to
9b178be
Compare
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 5, 2025
Summary: Moving the following from `ax/modelbridge/` to the new `ax/generation_strategy` directory ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68720587
|
This pull request was exported from Phabricator. Differential Revision: D68720587 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 5, 2025
Summary: Moving the following from `ax/modelbridge/` to the new `ax/generation_strategy` directory ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68720587
ItsMrLin
force-pushed
the
export-D68720587
branch
from
9b178be to
f5b8f46
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68720587 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 5, 2025
Summary: Moving the following from `ax/modelbridge/` to the new `ax/generation_strategy` directory ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68720587
ItsMrLin
force-pushed
the
export-D68720587
branch
from
f5b8f46 to
a9dff87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68720587 |
Summary: Moving the following from `ax/modelbridge/` to the new `ax/generation_strategy` directory ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68720587
ItsMrLin
force-pushed
the
export-D68720587
branch
from
a9dff87 to
363e73a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68720587 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3287 +/- ##
==========================================
- Coverage 95.75% 95.74% -0.01%
==========================================
Files 525 533 +8
Lines 52483 52513 +30
==========================================
+ Hits 50253 50280 +27
- Misses 2230 2233 +3 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 0f8660a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moving the following from
ax/modelbridge/to the newax/generation_strategydirectoryReviewed By: saitcakmak
Differential Revision: D68720587