Enable gen fallback model spec for GenerationNode #3209
Closed
+170
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3209 +/- ##
==========================================
- Coverage 95.72% 95.72% -0.01%
==========================================
Files 532 532
Lines 52479 52490 +11
==========================================
+ Hits 50238 50248 +10
- Misses 2241 2242 +1 ☔ View full report in Codecov by Sentry. |
ItsMrLin
force-pushed
the
export-D67232696
branch
from
d0a1b49 to
418f72a
Compare
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Dec 26, 2024
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Differential Revision: D67232696
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Dec 26, 2024
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Differential Revision: D67232696
ItsMrLin
force-pushed
the
export-D67232696
branch
from
418f72a to
138ef4b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Dec 28, 2024
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Differential Revision: D67232696
ItsMrLin
force-pushed
the
export-D67232696
branch
from
138ef4b to
57a1cc0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
ItsMrLin
force-pushed
the
export-D67232696
branch
from
57a1cc0 to
827f4af
Compare
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Jan 21, 2025
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Differential Revision: D67232696
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 12, 2025
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Reviewed By: saitcakmak Differential Revision: D67232696
ItsMrLin
force-pushed
the
export-D67232696
branch
from
827f4af to
d0c1b3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
…ion_config arguments (facebook#3360) Summary: As titled. Now the search_space and optimization_config will not be passed and by default will be extracted from the experiment. Reviewed By: lena-kashtelyan Differential Revision: D67803329
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Reviewed By: saitcakmak Differential Revision: D67232696
ItsMrLin
force-pushed
the
export-D67232696
branch
from
d0c1b3b to
e433d5a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
|
This pull request has been merged in 9805905. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen()
Differential Revision: D67232696