Enable gen fallback model spec for GenerationNode #3209
+177
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3209 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 513 513
Lines 51636 51651 +15
=======================================
+ Hits 49505 49520 +15
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
ItsMrLin
force-pushed
the
export-D67232696
branch
from
d0a1b49 to
418f72a
Compare
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Dec 26, 2024
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Differential Revision: D67232696
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Dec 26, 2024
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Differential Revision: D67232696
ItsMrLin
force-pushed
the
export-D67232696
branch
from
418f72a to
138ef4b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Dec 28, 2024
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Differential Revision: D67232696
ItsMrLin
force-pushed
the
export-D67232696
branch
from
138ef4b to
57a1cc0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
Summary: We pass kwargs to ModelSpec.fit in order to pass state extracted when this ModelSpec was used last, back into the ModelSpec, in GenNode.fit (https://fburl.com/code/uic21yuw). Along with these, we pass any kwargs manually specified to GenNode.fit, but this behavior is unused in GenStrategy (https://fburl.com/code/20kpa363) and can thus be reaped. That was a remnant of how we used to pass the state from facebook#1, in GenStrategy and not in GenNode (https://www.internalfb.com/diff/D32003890?dst_version_fbid=499298561323086&transaction_fbid=623265442134398) and should be deprecated. Created from CodeHub with https://fburl.com/edit-in-codehub Reviewed By: saitcakmak Differential Revision: D67803329
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen() Differential Revision: D67232696
ItsMrLin
force-pushed
the
export-D67232696
branch
from
57a1cc0 to
827f4af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67232696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allowing for gen fallback (default to sobol) upon running into specified error in GenerationNode.gen()
Differential Revision: D67232696