Raise error if enum not provided for a value we're trying to encode #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59925061 |
danielcohenlive
force-pushed
the
export-D59925061
branch
from
86d03b0 to
12c2d39
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59925061 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2587 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 489 489
Lines 47683 47703 +20
=======================================
+ Hits 45406 45426 +20
Misses 2277 2277 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D59925061 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jul 19, 2024
…acebook#2587) Summary: Pull Request resolved: facebook#2587 We probably want to let the user know if they're trying to encode/save a value we're going to drop. It turns out prior to this diff, a `None` for the enum that would be used to encode the value is treated differently than an actual enum that just happens to be missing the value. So a missing enum for experiment type would not raise an error if experiment type was passed. This should debatably only be done in test mode though. Silent failures are generally bad though and we could cause more problems down the road by not saving data we need to. Reviewed By: Cesar-Cardoso Differential Revision: D59925061
danielcohenlive
force-pushed
the
export-D59925061
branch
from
12c2d39 to
a3628cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59925061 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jul 19, 2024
…acebook#2587) Summary: Pull Request resolved: facebook#2587 We probably want to let the user know if they're trying to encode/save a value we're going to drop. It turns out prior to this diff, a `None` for the enum that would be used to encode the value is treated differently than an actual enum that just happens to be missing the value. So a missing enum for experiment type would not raise an error if experiment type was passed. This should debatably only be done in test mode though. Silent failures are generally bad though and we could cause more problems down the road by not saving data we need to. Reviewed By: Cesar-Cardoso Differential Revision: D59925061
danielcohenlive
force-pushed
the
export-D59925061
branch
from
a3628cb to
643e0c1
Compare
…acebook#2587) Summary: Pull Request resolved: facebook#2587 We probably want to let the user know if they're trying to encode/save a value we're going to drop. It turns out prior to this diff, a `None` for the enum that would be used to encode the value is treated differently than an actual enum that just happens to be missing the value. So a missing enum for experiment type would not raise an error if experiment type was passed. This should debatably only be done in test mode though. Silent failures are generally bad though and we could cause more problems down the road by not saving data we need to. Reviewed By: Cesar-Cardoso Differential Revision: D59925061
|
This pull request was exported from Phabricator. Differential Revision: D59925061 |
danielcohenlive
force-pushed
the
export-D59925061
branch
from
643e0c1 to
53b9d66
Compare
|
This pull request has been merged in be8e1f7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We probably want to let the user know if they're trying to encode/save a value we're going to drop. It turns out prior to this diff, a
Nonefor the enum that would be used to encode the value is treated differently than an actual enum that just happens to be missing the value. So a missing enum for experiment type would not raise an error if experiment type was passed.This should debatably only be done in test mode though. Silent failures are generally bad though and we could cause more problems down the road by not saving data we need to.
Differential Revision: D59925061