Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage support for ScaleMaternKernel & DEFAULT #2585

Closed
wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

Summary: Turns out these weren't in the storage registries, so they couldn't be serialized.

Differential Revision: D59891434

Summary: Turns out these weren't in the storage registries, so they couldn't be serialized.

Differential Revision: D59891434
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59891434

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.22%. Comparing base (56c9b46) to head (c3b734d).

Files Patch % Lines
ax/storage/botorch_modular_registry.py 66.66% 3 Missing ⚠️
ax/storage/json_store/decoders.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2585      +/-   ##
==========================================
- Coverage   95.22%   95.22%   -0.01%     
==========================================
  Files         489      489              
  Lines       47642    47680      +38     
==========================================
+ Hits        45369    45403      +34     
- Misses       2273     2277       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f57628d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants