chore(TS): minor changes to typescript notation to be compatible with…

… a 5.3.3

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [next]
 
+- chore(TS): minor changes to typescript notation to be compatible with a 5.3.3 [#9725](https://github.com/fabricjs/fabric.js/pull/9725)
 - fix(InteractiveObject): "borderOpacityWhenMoving" does not take effect on the child shapes within the group [#9374](https://github.com/fabricjs/fabric.js/issues/9734)
 - fix(SVGParser): Consider the transformMatrix of the clipPath owner as part of the clipPath trasnformation [#9750](https://github.com/fabricjs/fabric.js/pull/9750)
 - fix(StaticCanvas): setDimensions not requesting a render if options are not passed [#9710](https://github.com/fabricjs/fabric.js/pull/9710)

package.json

@@ -122,8 +122,6 @@
     "source-map-support": "^0.5.21",
     "testem": "^3.8.0",
     "tslib": "^2.4.1",
-    "typedoc": "^0.25.3",
-    "typedoc-plugin-markdown": "^3.17.0",
     "typescript": "^4.9.4",
     "v8-to-istanbul": "^9.1.0"
   },

src/Pattern/Pattern.ts

@@ -174,16 +174,24 @@ export class Pattern {
       patternWidth =
         repeat === 'repeat-y' || repeat === 'no-repeat'
           ? 1 + Math.abs(patternOffsetX || 0)
-          : ifNaN((patternSource.width as number) / width, 0),
+          : ifNaN(
+              ((patternSource as HTMLImageElement).width as number) / width,
+              0
+            ),
       patternHeight =
         repeat === 'repeat-x' || repeat === 'no-repeat'
           ? 1 + Math.abs(patternOffsetY || 0)
-          : ifNaN((patternSource.height as number) / height, 0);
+          : ifNaN(
+              ((patternSource as HTMLImageElement).height as number) / height,
+              0
+            );
 
     return [
       `<pattern id="SVGID_${id}" x="${patternOffsetX}" y="${patternOffsetY}" width="${patternWidth}" height="${patternHeight}">`,
-      `<image x="0" y="0" width="${patternSource.width}" height="${
-        patternSource.height
+      `<image x="0" y="0" width="${
+        (patternSource as HTMLImageElement).width
+      }" height="${
+        (patternSource as HTMLImageElement).height
       }" xlink:href="${this.sourceToString()}"></image>`,
       `</pattern>`,
       '',

src/canvas/StaticCanvas.ts

@@ -1230,11 +1230,11 @@ export class StaticCanvas<
           filler.offsetY - finalHeight / 2
         }" width="${
           (repeat === 'repeat-y' || repeat === 'no-repeat') && isPattern(filler)
-            ? filler.source.width
+            ? (filler.source as HTMLImageElement).width
             : finalWidth
         }" height="${
           (repeat === 'repeat-x' || repeat === 'no-repeat') && isPattern(filler)
-            ? filler.source.height
+            ? (filler.source as HTMLImageElement).height
             : finalHeight
         }" fill="url(#SVGID_${filler.id})"></rect>\n`
       );

src/filters/WebGLFilterBackend.ts

@@ -285,8 +285,8 @@ export class WebGLFilterBackend {
     } else {
       const texture = this.createTexture(
         this.gl,
-        textureImageSource.width,
-        textureImageSource.height,
+        (textureImageSource as HTMLImageElement).width,
+        (textureImageSource as HTMLImageElement).height,
         textureImageSource,
         filter
       );

src/shapes/Image.ts

@@ -602,7 +602,8 @@ export class FabricImage<
     ctx: CanvasRenderingContext2D
   ) {
     ctx.imageSmoothingEnabled = this.imageSmoothing;
-    // @ts-expect-error TS doesn't respect this type casting
+    // cant use ts-expect-error because of ts 5.3 cross check
+    // @ts-ignore TS doesn't respect this type casting
     super.drawCacheOnCanvas(ctx);
   }
 

src/shapes/Text/TextSVGExportMixin.ts

@@ -296,7 +296,8 @@ export class TextSVGExportMixin extends FabricObjectSVGExportMixin {
    * @return {String}
    */
   getSvgStyles(this: TextSVGExportMixin & FabricText, skipShadow?: boolean) {
-    // @ts-expect-error TS doesn't respect this type casting
+    // cant use ts-expect-error because of ts 5.3 cross check
+    // @ts-ignore TS doesn't respect this type casting
     return `${super.getSvgStyles(skipShadow)} white-space: pre;`;
   }