-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Secrets #20
Open
lcnuance
wants to merge
8
commits into
fabric8io:master
Choose a base branch
from
lcnuance:secrets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
db0aa2e
POC adding support for Daemonsets and Statefulsets. Using patch inste…
lcnuance c54c22f
Updating documentation
lcnuance 5691cf2
improving readme
lcnuance 9832bcf
Using already vendored version of yaml library
lcnuance a45134e
removing util lib
lcnuance 16ed3fa
Adding support for monitoring secrets
lcnuance 98ec086
restoring package path in local includes
lcnuance 22cb088
updating readme
lcnuance File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
*.swp | ||
bin/ | ||
_dist/ | ||
.idea | ||
golib | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,28 @@ | ||
# configmapcontroller | ||
|
||
This controller watches for changes to `ConfigMap` objects and performs rolling upgrades on their associated deployments for apps which are not capable of watching the `ConfigMap` and updating dynamically. | ||
This controller watches for changes to `ConfigMap` or `Secret` objects and performs rolling upgrades on their associated deployments,daemonsets or statefulsets for apps which are not capable of watching the `ConfigMap` and updating dynamically. | ||
|
||
This is particularly useful if the `ConfigMap` is used to define environment variables - or your app cannot easily and reliably watch the `ConfigMap` and update itself on the fly. | ||
This is particularly useful if the `ConfigMap` or `Secret` is used to define environment variables - or your app cannot easily and reliably watch the `ConfigMap` and update itself on the fly. | ||
|
||
## How to use configmapcontroller | ||
|
||
For a `Deployment` called `foo` have a `ConfigMap` called `foo`. Then add this annotation to your `Deployment` | ||
For an object(DaemonSet, Deployment, StatefulSet) called `foo` have a `ConfigMap` called `foo`. Then add this annotation to your manifest: | ||
|
||
```yaml | ||
metadata: | ||
annotations: | ||
configmap.fabric8.io/update-on-change: "foo" | ||
``` | ||
|
||
Then, providing `configmapcontroller` is running, whenever you edit the `ConfigMap` called `foo` the configmapcontroller will update the `Deployment` by adding the environment variable: | ||
For configmaps use the annotation configmap.frabric8.io/update-on-change. | ||
|
||
For secrets use the annotation secret.fabric8.io/update-on-change. | ||
|
||
Then, providing `configmapcontroller` is running, whenever you edit the `ConfigMap` called `foo` the configmapcontroller will update the `Deployment`, `StatefulSet` or `DaemonSet` by labeling it and hence triggering a rolling update on the object provided that .spec.updateStrategy.type is set to `RollingUpdate`. | ||
|
||
The label would be | ||
|
||
``` | ||
FABRICB_FOO_REVISION=${configMapRevision} | ||
``` | ||
|
||
This then triggers a rolling upgrade of your deployment's pods to use the new configuration. |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why it is necessary to ship the binary? Is using kubectl the only way to do this?