-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
341 get device name add error logging and none check #342
Merged
kthare10
merged 4 commits into
main
from
341-get_device_name-add-error-logging-and-none-check
Jun 24, 2024
Merged
341 get device name add error logging and none check #342
kthare10
merged 4 commits into
main
from
341-get_device_name-add-error-logging-and-none-check
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck for None in get_device_name
Pull Request Test Coverage Report for Build 9628455231Details
💛 - Coveralls |
…le change introduced in 0.22
Pull Request Test Coverage Report for Build 9628502953Details
💛 - Coveralls |
sajith
approved these changes
Jun 24, 2024
Re-running the test worked. I'm certain that it is a transient error that does not involve anything that we do. |
kthare10
deleted the
341-get_device_name-add-error-logging-and-none-check
branch
June 24, 2024 13:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#341
Addresses https://learn.fabric-testbed.net/forums/topic/get_device_name-returns-none/
as well as the deprecated function:
get_os_interface