Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

341 get device name add error logging and none check #342

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

kthare10
Copy link
Collaborator

#341
Addresses https://learn.fabric-testbed.net/forums/topic/get_device_name-returns-none/
as well as the deprecated function: get_os_interface

@kthare10 kthare10 linked an issue Jun 22, 2024 that may be closed by this pull request
@kthare10 kthare10 self-assigned this Jun 22, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 22, 2024

Pull Request Test Coverage Report for Build 9628455231

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+3.7%) to 21.979%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/interface.py 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/slice.py 1 8.42%
fabrictestbed_extensions/fablib/node.py 2 9.93%
fabrictestbed_extensions/fablib/interface.py 2 17.53%
Totals Coverage Status
Change from base Build 9322927172: 3.7%
Covered Lines: 1162
Relevant Lines: 4703

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 22, 2024

Pull Request Test Coverage Report for Build 9628502953

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 18.299%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/interface.py 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/interface.py 2 14.51%
Totals Coverage Status
Change from base Build 9322927172: -0.009%
Covered Lines: 1165
Relevant Lines: 4703

💛 - Coveralls

@kthare10 kthare10 requested review from sajith and paul-ruth June 22, 2024 21:53
@kthare10
Copy link
Collaborator Author

@sajith - not sure if this is related to new CI/CD changes pushed in #336
All tests pass but 3.10 tests fail to push report somewhere. This seems to be related to github workflows. Could you please take a look at this?

@sajith
Copy link
Member

sajith commented Jun 24, 2024

@sajith - not sure if this is related to new CI/CD changes pushed in #336 All tests pass but 3.10 tests fail to push report somewhere. This seems to be related to github workflows. Could you please take a look at this?

Re-running the test worked. I'm certain that it is a transient error that does not involve anything that we do.

@kthare10 kthare10 merged commit 46c4397 into main Jun 24, 2024
19 checks passed
@kthare10 kthare10 deleted the 341-get_device_name-add-error-logging-and-none-check branch June 24, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_device_name - add error logging and None check
3 participants