Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/ router 라우터 기능 및 테스트 코드 수정 코드리뷰 반영 #4

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

devbit4
Copy link
Member

@devbit4 devbit4 commented Jan 16, 2024

  • allias 사용을 위한 jest moduleNameMapper 추가
  • fetch 라이브러리 axios 추가
  • 가독성 및 유지보수성을 위해 api 분리(getArticleList,getArticle 등) 후 페이지에 삽입
  • 헤더, 배너, 푸터 등 공통 컴포넌트를 가진 Page 컴포넌트 생성해 페이지 랜더링 시 호출
  • 페이지 이동 시 scrollTo(0,0)추가
  • 테스트 코드 수정
    • describe nesting 을 통한 테스트 신뢰성 및 테스트 케이스 구분성 향상
    • 실제 페이지 import 후 테스트 추가

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@devbit4 devbit4 merged commit 6c79070 into main Jan 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant