Webpack + Babel for JSX + React 14 support. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use babel to compile jsx into lib dir for npm - use webpack + babel to compile into dist dir - remove jsx extension when importing files. - git ignore lib + dist - include lib, dist, src in npm files list.
| @@ -1,289 +0,0 @@ | |||
| Typeahead, written using the React.js library. | |||
There was a problem hiding this comment.
The whole dist folder is removed from source control with this PR.
It's been a while but I believe the readmes were identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for React 0.14 (#17), it expands on #21 but also includes updates to examples and removes warnings in test.
I had issues getting the existing build toolchain to work properly and since there was already talk of webpack (#2, #3), I switched to using Webpack + Babel 6 (only the react preset).
Running
npm buildwill now output the following:babel src --out-dir lib).I have removed the
distfolder from source control and have updated npm to include src, lib and dist. My intent with this was to remove compiled source from version control and use something like https://npmcdn.com to serve the dist builds from whats published on npm.