Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rose pine theme #9

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

basilbarge
Copy link
Contributor

My take on implementing the main Rose Pine theme palette

gierens and others added 3 commits January 10, 2025 01:04
Signed-off-by: basilbarge <[email protected]>
Co-authored-by: basilbarge <[email protected]>
Co-authored-by: gierens <[email protected]>
Signed-off-by: basilbarge <[email protected]>
Co-authored-by: basilbarge <[email protected]>
Co-authored-by: gierens <[email protected]>
Signed-off-by: basilbarge <[email protected]>
Co-authored-by: basilbarge <[email protected]>
Co-authored-by: gierens <[email protected]>
@gierens gierens changed the title feat: add Rose Pine main theme feat: add rose pine theme Jan 10, 2025
Copy link
Member

@gierens gierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the files to rose-pine removing the main, seems unnecessary, at least until we have more than a single rose-pine theme.

I also squashed fixes into the commits that created the corresponding sources and rewrote messages to conform to conventional commit quidelines.

Other than that, LGTM, thanks for the contribution :)

@gierens gierens merged commit 266feb8 into eza-community:main Jan 10, 2025
2 checks passed
@basilbarge
Copy link
Contributor Author

Okay awesome. Thanks for the feedback, this is my first time contributing to someone else's public project :)

@basilbarge basilbarge deleted the rose-pine-main branch January 10, 2025 14:37
@gierens
Copy link
Member

gierens commented Jan 13, 2025

@basilbarge awesome, congratulations! :)

A couple to tips, because reviewers on other projects can be more demanding of PR authors:

  • PR should usually be self-contained but try to make them a small as possible for easier review, you've done that, so perfect ☑️
  • stick to small/atomic commits, makes for a cleaner history and squashing commits is easier than picking them apart, you also did that, great ☑️
  • get familiar with rewriting your commits, git reset, git commit --amend and particularly git rebase -i. While it's fine to just commit as you go while still developing the PR, it is good practice to cleanup the history once it is ready for review. So for example if commit 1 adds a feature and in commit 4 you fix a typo you made in commit 1, then squashing commit 4 into commit 1 would clean up the history. 🔲
  • also sometimes there a contribution guidelines on projects, like using conventional commit style commit messages, that's more my fault that this wasn't done already, because we haven't yet documented it here. 🔲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants