-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rose pine theme #9
Conversation
6d6c57d
to
c6d6715
Compare
Signed-off-by: basilbarge <[email protected]> Co-authored-by: basilbarge <[email protected]> Co-authored-by: gierens <[email protected]>
Signed-off-by: basilbarge <[email protected]> Co-authored-by: basilbarge <[email protected]> Co-authored-by: gierens <[email protected]>
Signed-off-by: basilbarge <[email protected]> Co-authored-by: basilbarge <[email protected]> Co-authored-by: gierens <[email protected]>
3be1494
to
69d00ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the files to rose-pine
removing the main
, seems unnecessary, at least until we have more than a single rose-pine theme.
I also squashed fixes into the commits that created the corresponding sources and rewrote messages to conform to conventional commit quidelines.
Other than that, LGTM, thanks for the contribution :)
Okay awesome. Thanks for the feedback, this is my first time contributing to someone else's public project :) |
@basilbarge awesome, congratulations! :) A couple to tips, because reviewers on other projects can be more demanding of PR authors:
|
My take on implementing the main Rose Pine theme palette