Skip to content

Commit

Permalink
Build tools:
Browse files Browse the repository at this point in the history
* Made `make-jars.pl` respect the quiet flag better, by propagating it to the `zip` program (when it uses zip).
  • Loading branch information
Eyal Rozenberg committed Sep 5, 2020
1 parent 1460311 commit 9acaa39
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions buildtools/make-jars.pl
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@
$zipmoveopt = "-0";
}

my $zipquietopt = "";
if ("$fileformat" eq "jar" || "$fileformat" eq "both") {
$zipquietopt = "-q";
}

my $nofilelocks = 0;
if (defined($::opt_l)) {
$nofilelocks = 1;
Expand Down Expand Up @@ -271,13 +276,13 @@ sub JarIt

#print "$zipprog $zipmoveopt -uX $jarchive $subargs\n";
#print "Length of subargs: " . length($subargs) . "\n";
system("$zipprog $zipmoveopt $argOpt $jarchive $subargs") == 0 or
system("$zipprog $zipquietopt $zipmoveopt $argOpt $jarchive $subargs") == 0 or
$err = $? >> 8;
zipErrorCheck($err,$lockfile);
}
#print "Length of args: " . length($args) . "\n";
#print "$zipprog $zipmoveopt -uX $jarchive $args\n";
system("$zipprog $zipmoveopt $argOpt $jarchive $args") == 0 or
system("$zipprog $zipquietopt $zipmoveopt $argOpt $jarchive $args") == 0 or
$err = $? >> 8;
zipErrorCheck($err,$lockfile);
}
Expand All @@ -295,13 +300,13 @@ sub JarIt

#print "$zipprog $zipmoveopt -X $jarchive $subargs\n";
#print "Length of subargs: " . length($subargs) . "\n";
system("$zipprog $zipmoveopt -X $jarchive $subargs") == 0 or
system("$zipprog $zipquietopt $zipmoveopt -X $jarchive $subargs") == 0 or
$err = $? >> 8;
zipErrorCheck($err,$lockfile);
}
#print "Length of args: " . length($overrides) . "\n";
#print "$zipprog $zipmoveopt -X $jarchive $overrides\n";
system("$zipprog $zipmoveopt -X $jarchive $overrides\n") == 0 or
system("$zipprog $zipquietopt $zipmoveopt -X $jarchive $overrides\n") == 0 or
$err = $? >> 8;
zipErrorCheck($err,$lockfile);
}
Expand Down

0 comments on commit 9acaa39

Please sign in to comment.