Remove remaining temp file after Artifactory download (jfrog#1036)

eyalbe4 · Nov 3, 2024 · 63e06cd · 63e06cd
1 parent ba61c56
commit 63e06cd
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/artifactory/services/download.go b/artifactory/services/download.go
@@ -3,17 +3,18 @@ package services
 import (
 	"errors"
 	"fmt"
-	"github.com/jfrog/build-info-go/entities"
-	"github.com/jfrog/gofrog/crypto"
-	ioutils "github.com/jfrog/gofrog/io"
-	"github.com/jfrog/gofrog/version"
 	"net/http"
 	"os"
 	"path"
 	"path/filepath"
 	"sort"
 	"strings"
 
+	"github.com/jfrog/build-info-go/entities"
+	"github.com/jfrog/gofrog/crypto"
+	ioutils "github.com/jfrog/gofrog/io"
+	"github.com/jfrog/gofrog/version"
+
 	"github.com/jfrog/jfrog-client-go/http/httpclient"
 
 	"github.com/jfrog/gofrog/parallel"

diff --git a/artifactory/services/utils/searchutil.go b/artifactory/services/utils/searchutil.go
@@ -242,25 +242,25 @@ func FilterResultsByBuild(specFile *CommonParams, flags CommonConf, requiredArti
 // AND
 // 2. Properties weren't fetched during 'build' filtering
 // Otherwise, nil will be returned
-func fetchProps(specFile *CommonParams, flags CommonConf, requiredArtifactProps RequiredArtifactProps, reader *content.ContentReader) (*content.ContentReader, error) {
+func fetchProps(specFile *CommonParams, flags CommonConf, requiredArtifactProps RequiredArtifactProps, reader *content.ContentReader) (r *content.ContentReader, err error) {
 	if !includePropertiesInAqlForSpec(specFile) && specFile.Build == "" && requiredArtifactProps != NONE {
 		var readerWithProps *content.ContentReader
-		var err error
 		switch requiredArtifactProps {
 		case ALL:
 			readerWithProps, err = searchProps(specFile.Aql.ItemsFind, "*", []string{"*"}, flags)
 		case SYMLINK:
 			readerWithProps, err = searchProps(specFile.Aql.ItemsFind, "symlink.dest", []string{"*"}, flags)
 		}
 		if err != nil {
-			return nil, err
+			return
 		}
 		defer func() {
 			err = errors.Join(err, errorutils.CheckError(reader.Close()))
+			err = errors.Join(err, errorutils.CheckError(readerWithProps.Close()))
 		}()
-		return loadMissingProperties(reader, readerWithProps)
+		r, err = loadMissingProperties(reader, readerWithProps)
 	}
-	return nil, nil
+	return
 }
 
 func aqlSearch(aqlQuery string, flags CommonConf) (*content.ContentReader, error) {

diff --git a/http/httpclient/client.go b/http/httpclient/client.go
@@ -3,8 +3,10 @@ package httpclient
 import (
 	"bytes"
 	"context"
-	"github.com/minio/sha256-simd"
 	"strings"
+
+	"github.com/minio/sha256-simd"
+
 	//#nosec G505 -- sha1 is supported by Artifactory.
 	"crypto/sha1"
 	"encoding/hex"