Refactor and shorten component creation #1370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea. I would like to move forward with this. please rebase again and resolve the merge conflicts! |
alexmaco
force-pushed
the
refactor
branch
2 times, most recently
from
c5f06a1 to
c6e4713
Compare
|
@extrawurst perhaps another look at this? |
extrawurst
reviewed
Jan 8, 2024
| @@ -35,28 +35,18 @@ impl ChangesComponent { | |||
| //TODO: fix | |||
| #[allow(clippy::too_many_arguments)] | |||
There was a problem hiding this comment.
is this fixed by the change? can it be removed?
extrawurst
reviewed
Jan 8, 2024
| key_config: SharedKeyConfig, | ||
| options: SharedOptions, | ||
| ) -> Self { | ||
| pub fn new(env: &crate::app::Environment) -> Self { |
There was a problem hiding this comment.
so far the other places import this instead of fully-qualifying. lets stay consistent
extrawurst
reviewed
Jan 8, 2024
|
|
||
| /// The need to construct a "whatever" environment only arises in testing right now | ||
| #[cfg(test)] | ||
| impl Default for Environment { |
There was a problem hiding this comment.
does it need to be the Default trait though? lets make it explicit and just make it a static fn new_test_env
extrawurst
reviewed
Jan 8, 2024
| theme: Default::default(), | ||
| key_config: Default::default(), | ||
| repo: RefCell::new(RepoPath::Path(Default::default())), | ||
| options: Default::default(), |
extrawurst
reviewed
Jan 8, 2024
| @@ -32,6 +32,17 @@ pub struct Options { | |||
| data: OptionsData, | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| impl Default for Options { | |||
extrawurst
requested changes
Jan 8, 2024
|
@alexmaco are you still on this? |
|
made these cleanups myself now and will merge as part of #2043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
I followed the checklist:
make checkwithout errors