Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-sass dependency #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tommygnr
Copy link

@tommygnr tommygnr commented Jun 6, 2023

What:

Remove node-sass from package.json

Why:

node-sass is not a direct dependency of this library so shouldn't be defined in package.json

How:

npm uninstall node-sass

Checklist:

  • Documentation added/updated (N/A)
  • Typescript definitions updated (N/A)
  • Tests added and passing (N/A)
  • Ready to be merged

This is not a direct dependency of this application so shouldn't be defined in package.json
@jwoo92 jwoo92 self-requested a review July 8, 2023 16:32
@stale
Copy link

stale bot commented Aug 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that became stale label Aug 28, 2023
@Conor-Hinchee
Copy link
Collaborator

Thanks for the PR! It looks like we have a direct Dev dependency on node-sass to complete builds and with our current node version, we are not able to upgrade to the latest of node-sass and it's deprecated. Looks like we could look into migrating to https://sass-lang.com/dart-sass. We could pivot this PR to that venture otherwise we can close this and open an issue.

@stale stale bot removed the stale Issues that became stale label Sep 22, 2023
@Conor-Hinchee Conor-Hinchee self-requested a review September 22, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants