[build-tools] Do not add repack.yml to project directory
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
stanley/eng-14684-add-steps-to-build-job
to
main
January 17, 2025 15:00
sjchmiela
force-pushed
the
stanley/eng-14735-stop-adding-repackyml-to-peoples-project-directories
branch
from
4bf33b5 to
8e42a87
Compare
sjchmiela
force-pushed
the
stanley/eng-14735-stop-adding-repackyml-to-peoples-project-directories
branch
from
8e42a87 to
009f854
Compare
sjchmiela
force-pushed
the
stanley/eng-14735-stop-adding-repackyml-to-peoples-project-directories
branch
from
801ab16 to
bc84adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If developers have
requireCommit: truein theireas.jsonconfiguration, when they try to publish an update with Workflows it fails, because there are uncommitted files in repository —__eas/repack.yml.How
Instead of copying
repack.ymlinto people's projects we're going to definestepsin code.Test Plan
Tested manually.