Update setup and improve arch detection / support for linux #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For `aarch64`: set default to `cortexa57`
* Change default compiler to `gcc`
* For `ppc64le`: set default to `power9`
* Change default compiler to `gcc`
* For `x86_64`:
* Detect support for `znver2` and `skylake-avx512` flags
* Add alternative to `x86_64` without `znver2` as `zx86_64_no_znver2`
* Set default to `x86_64_no_skx` (neither flag supported or detection
fails)
* For remaining: set default to `generic` instead of `x86_64`
* Update cythonize setup * Exclude generated .c files * Clean up imports
* Remove detailed numpy build constraints from `pyproject.toml` because
it is too difficult to maintain for many architectures
* These constraints are more a reflection of what is available on
pypi as binary wheels rather than any real build requirements that
it is necessary for users to follow when building from source
* Users building their own binary packages will need to enforce the
constraints that make sense in their environments, e.g., the `conda`
compatible numpy pins
* Keep the build constraints in `build-constraints.txt` for use with our
builds
* Our builds with wheelwright are built against the earliest
compatible binary versions of numpy on pypi
* These constraints are documented within the distribution
adrianeboyd
changed the title
* Refactor compiler flag check
This was
linked to
issues
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cythonize in setup
Remove detailed numpy constraints from
pyproject.tomlImprove arch detection / support for linux and darwin:
linux:
aarch64:cortexa57gccppc64le:power9gccx86_64:znver1,znver2, andskylake-avx512flagsx86_64withoutznver2aszx86_64_no_zen2generic(no flags supported or detection fails)genericinstead ofx86_64darwin:
genericfor non-x86_64