aarch64: check for LITTLE cores #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for bug explosion#13 : add logic to setup.py to detect aarch64 LITTLE cores for which BLIS has configure flag BLIS_ARCH="cortexa53". All other cores will configure with BLIS_ARCH="cortexa57".
|
Thanks! I'm running blind a bit on this because I don't have a machine set up with that hardware. Really appreciate the contributions. Btw the release of this is just waiting on me to fix some CI problems. I hope I can do that today or tomorrow. |
|
Hi @honnibal there are several arm64 machines on the GCC farm: https://cfarm.tetaneutral.net/machines/list/ you can get an account pretty easily if you mention that you need access to the machines to test cython-blis on various architectures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for bug #13
This patch adds logic to setup.py to detect aarch64 LITTLE cores for which BLIS has configure flag BLIS_ARCH="cortexa53".
All other cores will configure with BLIS_ARCH="cortexa57".