Add generic typing to registry #69
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
commented
Feb 20, 2024
| @@ -22,10 +23,14 @@ def create(*namespace: str, entry_points: bool = False) -> "Registry": | |||
| """ | |||
| if check_exists(*namespace): | |||
| raise RegistryError(f"Namespace already exists: {namespace}") | |||
| return Registry(namespace, entry_points=entry_points) | |||
|
|
|||
| if generic_type is None: | |||
There was a problem hiding this comment.
This isn't exactly right...but I couldn't figure out how to get mypy to accept a direct default for the argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is something y'all are interested in adding, but I wanted to use catalogue with static typing on what the registry contains (Even though you've called it
funceverywhere, its quite useful to have other types in the registry). Thought I'd see if you wanted to upstream the typing change.