fix(sc-119059): set IPv6 node external IP if there is an address, instead of IPv6Enabled flag #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tance of IPv6Enabled flag Regarding an issue we found internally, there is no ipv6-enabled flag in the payload, meaning IPv6 addresses are ignored by CCM This will result by IPv4 only node status. IPv6 addresses are mandatory here since cilium 1.17
nerzhul
force-pushed
the
feat/sc-119059
branch
from
915cb4f to
432f4fc
Compare
nerzhul
force-pushed
the
feat/sc-119059
branch
from
432f4fc to
ee61d5e
Compare
zyegfryed
changed the title
zyegfryed
approved these changes
Feb 5, 2025
|
putted back on draft, the issue is more complex than this assumption (which works but it's not what we expect). |
|
thanks for the review. I'm discarding the PR as it's not relevant. CCM is working fine. The issue is our --node-ip flag passed with the kubelet setting alpha.kubernetes.io/provided-node-ip annotation with a single IPv4. This is not patched after restart of the kubelet or if annotation is missing. It's only set on creation |
|
Superseded by exoscale/puppet8#1649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding an issue we found internally, AnnotationAlphaProvidedIPAddr is set to a Single IP, meaning IPv6 addresses are ignored by CCM This will result by IPv4 only node status. IPv6 addresses are mandatory here since cilium 1.17.
If IPv6 is enabled on cilium and node don't have IPv6 addresses, the related pod startup fail with this error:
Also fix some golang reported vuln + testify dep
Note: after publishing this to master (after validation on our env) we should produce a release to be used asap on our Dual Stack cilium backed environments
Checklist
(For exoscale contributors)
Testing