Add better error for MaxIterationsReached

app/javascript/interpreter/error.ts

@@ -118,6 +118,7 @@ export type RuntimeErrorType =
   | 'ExpectedFunctionNotFound'
   | 'ExpectedFunctionHasWrongArguments'
   | 'InvalidNestedFunction'
+  | 'MaxIterationsReached'
 
 export type StaticErrorType =
   | DisabledLanguageFeatureErrorType

app/javascript/interpreter/executor.ts

@@ -399,7 +399,7 @@ export class Executor {
             statement.location.absolute.begin + 22
           )
         )
-        this.error('InfiniteLoop', errorLoc)
+        this.error('MaxIterationsReached', errorLoc, { maxIterations })
       }
 
       this.guardInfiniteLoop(statement.location)

app/javascript/interpreter/locales/en/translation.json

@@ -70,6 +70,7 @@
       "CouldNotFindFunction": "Jiki couldn't find a function with the name `{{name}}`.",
       "CouldNotFindFunctionWithSuggestion": "Jiki couldn't find a function with the name `{{name}}`. Maybe you meant to use the `{{suggestion}}` function instead?",
       "InfiniteLoop": "Your code ran for too long and we stopped it to prevent an infinite loop.",
+      "MaxIterationsReached": "You hit the maximum number of iterations allowed in this exercise ({{maxIterations}}). Try and find a more efficient way to solve the exercise.",
       "InvalidBinaryExpression": "Invalid binary expression",
       "InvalidExpression": "Invalid expression",
       "InvalidIndexGetterTarget": "Can't index object, only dictionaries and arrays can be indexed'.",

app/javascript/interpreter/locales/system/translation.json

@@ -71,6 +71,7 @@
       "CouldNotFindFunction": "CouldNotFindFunction: name: {{name}}",
       "CouldNotFindFunctionWithSuggestion": "CouldNotFindFunctionWithSuggestion: name: {{name}}, suggestion: {{suggestion}}",
       "InfiniteLoop": "InfiniteLoop",
+      "MaxIterationsReached": "MaxIterationsReached: maxIterations: {{maxIterations}}",
       "InvalidBinaryExpression": "InvalidBinaryExpression",
       "InvalidExpression": "InvalidExpression",
       "InvalidIndexGetterTarget": "InvalidIndexGetterTarget",

test/javascript/interpreter/runtimeErrors.test.ts

@@ -166,4 +166,21 @@ describe('Runtime errors', () => {
       )
     })
   })
+  test('MaxIterationsReached', () => {
+    const code = `repeat_until_game_over do
+                  end`
+
+    const maxIterations = 50
+    const { frames } = interpret(code, {
+      languageFeatures: { maxRepeatUntilGameOverIterations: maxIterations },
+    })
+    expectFrameToBeError(
+      frames[0],
+      'repeat_until_game_over',
+      'MaxIterationsReached'
+    )
+    expect(frames[0].error!.message).toBe(
+      `MaxIterationsReached: maxIterations: ${maxIterations}`
+    )
+  })
 })