Be very certain tasks are completed before showing modal #7408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There logically HAS to be a place where
areAllTasksCompleted
is incorrectly being set totrue
for the completed modal to appear at the wrong time.As far as I can tell, there are three files that the issue could be in. I've gone through them.
app/javascript/components/bootcamp/SolveExercisePage/store/taskStore/getInitialTasks.ts
false
app/javascript/components/bootcamp/SolveExercisePage/store/taskStore/processTasks.ts
false
true
if there are no tests in the task for some reason. I've guarded that.app/javascript/components/bootcamp/SolveExercisePage/store/taskStore/taskStore.ts
undefined
- I've checked and we're never doing=== false
so this is ok.