Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be very certain tasks are completed before showing modal #7408

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

iHiD
Copy link
Member

@iHiD iHiD commented Jan 29, 2025

There logically HAS to be a place where areAllTasksCompleted is incorrectly being set to true for the completed modal to appear at the wrong time.

As far as I can tell, there are three files that the issue could be in. I've gone through them.

app/javascript/components/bootcamp/SolveExercisePage/store/taskStore/getInitialTasks.ts

  • L16: Default to false
  • L35 proxies to processTasks

app/javascript/components/bootcamp/SolveExercisePage/store/taskStore/processTasks.ts

  • L17: Changed default to false
  • L41: Increments the numberOfCompletedTasks guard. This could flip to true if there are no tests in the task for some reason. I've guarded that.
  • L61/63 - Changed to add a guard.

app/javascript/components/bootcamp/SolveExercisePage/store/taskStore/taskStore.ts

  • L11: Sets to undefined - I've checked and we're never doing === false so this is ok.
  • L41 proxies to processTasks above

@iHiD iHiD requested a review from dem4ron as a code owner January 29, 2025 12:45
@iHiD iHiD merged commit 77501d3 into main Jan 29, 2025
40 checks passed
@iHiD iHiD deleted the be-certain-tasks-are-completed branch January 29, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant