Remove visitor pattern and add descriptions (#7361)

* WIP * Remove Javascript interpreter * Add tests for all exercises * Tidy imports * Tidy imports * Remove visitor pattern and add descriptions * Improve descriptions further * Keep simplifying
exercism · Jan 22, 2025 · 86e1fc1 · 86e1fc1
1 parent 7034396
commit 86e1fc1
Show file tree

Hide file tree

Showing 23 changed files with 930 additions and 992 deletions.
diff --git a/app/css/bootcamp/components/editor-information-tooltip.css b/app/css/bootcamp/components/editor-information-tooltip.css
@@ -10,11 +10,14 @@
         @apply bg-thick-border-blue px-[6px] py-[1px] rounded-5;
     }
 
+    pre + p {
+        @apply mt-6;
+    }
     pre {
-        @apply mt-4;
+        @apply mt-2;
     }
 
-    p:not(:last-of-type) {
+    p:not(:last-child) {
         @apply mb-10;
     }
     ul {

diff --git a/...otcamp/SolveExercisePage/CodeMirror/extensions/end-line-information/information-widget.ts b/...otcamp/SolveExercisePage/CodeMirror/extensions/end-line-information/information-widget.ts
@@ -90,7 +90,7 @@ export class InformationWidget extends WidgetType {
     if (!this.tooltip) return
     this.arrowElement = document.createElement('div')
     this.arrowElement.classList.add('tooltip-arrow')
-    this.tooltip.appendChild(this.arrowElement)
+    this.tooltip.prepend(this.arrowElement)
   }
 
   // @ts-ignore

diff --git a/app/javascript/interpreter/error.ts b/app/javascript/interpreter/error.ts
@@ -59,7 +59,6 @@ export type SyntaxErrorType =
   | 'MissingColonAfterKey'
   | 'MissingFieldNameOrIndexAfterOpeningBracket'
   | 'InvalidTemplateLiteral'
-  | 'MissingColonAfterThenBranchOfTernaryOperator'
   | 'NumberEndsWithDecimalPoint'
   | 'NumberWithMultipleDecimalPoints'
   | 'NumberContainsAlpha'
@@ -108,6 +107,7 @@ export type RuntimeErrorType =
   | 'InvalidIndexSetterTarget'
   | 'UnexpectedEqualsForEquality'
   | 'VariableAlreadyDeclared'
+  | 'VariableNotDeclared'
 
 export type StaticErrorType =
   | DisabledLanguageFeatureErrorType

diff --git a/app/javascript/interpreter/evaluation-result.ts b/app/javascript/interpreter/evaluation-result.ts
@@ -1,28 +1,12 @@
 import type { TokenType } from './token'
 
-export type EvaluationResultVariableStatement = {
-  type: 'VariableStatement'
+export type EvaluationResultSetVariableStatement = {
+  type: 'SetVariableStatement'
   value: any
   name: string
   data?: Record<string, any>
 }
 
-export type EvaluationResultTernaryExpression = {
-  type: 'TernaryExpression'
-  value: any
-  condition: EvaluationResult
-  data?: Record<string, any>
-}
-
-export type EvaluationResultUpdateExpression = {
-  type: 'UpdateExpression'
-  operand: any
-  operator: any
-  value: any
-  newValue: any
-  data?: Record<string, any>
-}
-
 export type EvaluationResultIfStatement = {
   type: 'IfStatement'
   value: any
@@ -105,11 +89,10 @@ export type EvaluationResultConstantStatement = {
   data?: Record<string, any>
 }
 
-export type EvaluationResultAssignExpression = {
-  type: 'AssignExpression'
+export type EvaluationResultChangeVariableStatement = {
+  type: 'ChangeVariableStatement'
   name: string
-  operator: TokenType
-  value: any
+  oldValue: any
   newValue: any
   data?: Record<string, any>
 }
@@ -171,10 +154,9 @@ export type EvaluationResultCallExpression = {
 }
 
 export type EvaluationResult =
-  | EvaluationResultVariableStatement
+  | EvaluationResultSetVariableStatement
   | EvaluationResultUpdateExpression
   | EvaluationResultConstantStatement
-  | EvaluationResultTernaryExpression
   | EvaluationResultIfStatement
   | EvaluationResultExpressionStatement
   | EvaluationResultForeachStatement
@@ -188,7 +170,7 @@ export type EvaluationResult =
   | EvaluationResultBinaryExpression
   | EvaluationResultUnaryExpression
   | EvaluationResultGroupingExpression
-  | EvaluationResultAssignExpression
+  | EvaluationResultChangeVariableStatement
   | EvaluationResultGetExpression
   | EvaluationResultSetExpression
   | EvaluationResultTemplateTextExpression