Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tp/prerequisites #1924

Merged
merged 4 commits into from
Oct 29, 2022

Conversation

TomPradat
Copy link
Contributor

@TomPradat TomPradat commented Oct 1, 2022

This partially fixes the issue #983

Would that be possible to get an hacktoberfest label on this PR please 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

Dear TomPradat

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

Comment on lines +679 to +685
"prerequisites": [
"strings",
"for-loops",
"regular-expressions",
"arrays",
"objects"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/word-count/solutions/TomPradat

I chose for-loops instead of array-transformations given the difficulty of the exercise. I omitted conditionals as the concept is a prerequisite of objects and for-loops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I think the difficulty of this exercise is underrated, regex are not that easy to deal with, I'd give a 4 or 5. If you agree I can make a new PR ? Or just a separated commit on this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a new PR but yeah let's bump it.

@@ -658,7 +658,7 @@
"name": "Scrabble Score",
"uuid": "11771d47-1109-4579-a62b-e0b8e9583485",
"practices": [],
"prerequisites": [],
"prerequisites": ["strings", "array-transformations"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/scrabble-score/solutions/TomPradat

I only put 2 prerequisites because array-transformations already "includes" many other concetps

@SleeplessByte SleeplessByte added the hacktoberfest-accepted Opt-in to hacktoberfest label Oct 2, 2022
@@ -667,7 +667,7 @@
"name": "Allergies",
"uuid": "9d33d21c-e695-427f-9f58-dd9498d61318",
"practices": [],
"prerequisites": [],
"prerequisites": ["classes", "math", "numbers", "for-loops", "arrays"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/allergies/solutions/TomPradat

I used array transformations a lot, but looking at the community solutions, I found this one that I like better. That's why I didn't put array-transformations as a prerequisite, you can easily replace the filter method with a for loop

math is not in the list of concepts but is present a lot in other exercises' prerequisites.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Myeah I wonder what happens with math. I guess we'll find out after merging this :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I read somewhere that the exercise is only unlocked after all concepts have been completed. I couldn't find where I saw that though

@TomPradat TomPradat force-pushed the feature/TP/prerequisites branch from 373f7b5 to 321959c Compare October 2, 2022 19:19
@@ -685,7 +691,7 @@
"name": "Bank Account",
"uuid": "8beedf70-28b4-4cfb-ab53-309ee6f6aa78",
"practices": [],
"prerequisites": [],
"prerequisites": ["classes", "conditionals", "numbers"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/bank-account/solutions/TomPradat

This is pretty straightforward IMO

@TomPradat TomPradat marked this pull request as ready for review October 2, 2022 19:21
@TomPradat TomPradat force-pushed the feature/TP/prerequisites branch from 321959c to 2de4d39 Compare October 9, 2022 16:22
@SleeplessByte SleeplessByte merged commit f483dce into exercism:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Opt-in to hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants