-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tp/prerequisites #1924
Feature/tp/prerequisites #1924
Conversation
Dear TomPradatThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
"prerequisites": [ | ||
"strings", | ||
"for-loops", | ||
"regular-expressions", | ||
"arrays", | ||
"objects" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/word-count/solutions/TomPradat
I chose for-loops
instead of array-transformations
given the difficulty of the exercise. I omitted conditionals
as the concept is a prerequisite of objects
and for-loops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I think the difficulty of this exercise is underrated, regex are not that easy to deal with, I'd give a 4 or 5. If you agree I can make a new PR ? Or just a separated commit on this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a new PR but yeah let's bump it.
@@ -658,7 +658,7 @@ | |||
"name": "Scrabble Score", | |||
"uuid": "11771d47-1109-4579-a62b-e0b8e9583485", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["strings", "array-transformations"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/scrabble-score/solutions/TomPradat
I only put 2 prerequisites because array-transformations
already "includes" many other concetps
@@ -667,7 +667,7 @@ | |||
"name": "Allergies", | |||
"uuid": "9d33d21c-e695-427f-9f58-dd9498d61318", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["classes", "math", "numbers", "for-loops", "arrays"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/allergies/solutions/TomPradat
I used array transformations a lot, but looking at the community solutions, I found this one that I like better. That's why I didn't put array-transformations
as a prerequisite, you can easily replace the filter
method with a for loop
math
is not in the list of concepts but is present a lot in other exercises' prerequisites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Myeah I wonder what happens with math
. I guess we'll find out after merging this :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I read somewhere that the exercise is only unlocked after all concepts have been completed. I couldn't find where I saw that though
373f7b5
to
321959c
Compare
@@ -685,7 +691,7 @@ | |||
"name": "Bank Account", | |||
"uuid": "8beedf70-28b4-4cfb-ab53-309ee6f6aa78", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["classes", "conditionals", "numbers"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/bank-account/solutions/TomPradat
This is pretty straightforward IMO
321959c
to
2de4d39
Compare
This partially fixes the issue #983
Would that be possible to get an hacktoberfest label on this PR please 🙏