Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: only fetch prob-specs repo once #850

Closed
wants to merge 1 commit into from

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom requested a review from ee7 January 11, 2024 14:57
@ee7
Copy link
Member

ee7 commented Jan 18, 2024

Can we close this PR iin favor of #845? I think I'd prefer just to include it in that one - it's not logically separate, right?

@ErikSchierboom
Copy link
Member Author

it's not logically separate, right?

Well, depends on your viewpoint. But I'm fine with closing it here.

@ee7
Copy link
Member

ee7 commented Jan 18, 2024

I think it's something that could be a separate commit, I'd just prefer that it not be a separate commit directly on the main branch. Rationale: theoretically, if we wanted to revert the commit that adds the create functionality, maybe we should revert this change too (because it only exists to prepare for the upcoming implementation of create).

If you want to have it as a separate commit in the history on main, I'd argue that it should be a separate commit in a branch for create that's merged via merge commit. But I wouldn't bother.

@ee7 ee7 closed this Jan 18, 2024
@ee7 ee7 deleted the probspec-init-once branch January 18, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants