.github: separate release creation from uploading assets #792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the
.github/bin/publish-release
script handled both:with the intention that the first build job to finish would create the release with one asset, and each later job would upload an asset.
The logic was like:
But this had a race. For example, if two build jobs finished at nearly the same moment, they could each create a draft release. This race was almost never encountered in practice, and was easily resolved by deleting a draft release and restarting a build job, but it's worth resolving.
Add an initial build job to create a draft release that has no assets, and make the later build jobs only upload to that release.
This fixes the race, and makes it easier to share logic between the native build jobs and the cross-compiling build jobs.
Fixes: #551
Refs: #789
To-do: