This repository was archived by the owner on Jan 5, 2019. It is now read-only.
Do not charge gas for interface methods #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cdetrio
reviewed
May 28, 2018
| gasCount += op.fee | ||
| // do not charge gas for interface methods | ||
| // TODO: implement proper gas charging and enable this here | ||
| if (opint < 0x30 || (opint > 0x45 && opint < 0xa0)) { |
There was a problem hiding this comment.
would be better to have an explicit list of opcodes which translate to interface methods and opcodes that don't
There was a problem hiding this comment.
relevant doc is here ewasm/design#81
There was a problem hiding this comment.
Yes, that is an option which came up (add a field to opcodes.js), but this was a quick and dirty way to progress.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.