Skip to content

Commit

Permalink
replace jupyter notebook with python script generated from it
Browse files Browse the repository at this point in the history
  • Loading branch information
jwasinger committed Sep 24, 2020
1 parent 232ccd6 commit d766b04
Show file tree
Hide file tree
Showing 5 changed files with 5,025 additions and 6,481 deletions.
10 changes: 3 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ benchmark_wasm_engines:

benchmark: benchmark_scout_engines benchmark_wasm_engines benchmark_evm_engines benchmark_evm_precompiles

# Default timeout is 30 seconds, but our cells are quite big, increase it to 120 seconds.
# More info: https://github.com/jupyter/nbconvert/issues/256#issuecomment-188405852
# TODO: upgrade to newer nbconvert which sets the timeout to off by default
notebook:
cd notebooks && \
jupyter nbconvert --execute --ExecutePreprocessor.timeout=120 --to notebook --inplace wasm-engines.ipynb && \
python3 -m nbconvert --ClearOutputPreprocessor.enabled=True --inplace wasm-engines.ipynb # delete some cruft from the notebook to make it more VCS-friendly
generate_charts:
cd charts && \
python3 generate-charts.py
18 changes: 2 additions & 16 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,27 +86,13 @@ Run benchmarks
make benchmark_scout_engines
```

## Generate charts using jupyter notebooks
## Generate charts

Install python deps for plotting benchmark graphs:

```shell
$ pip install -r requirements.txt
```

Launch a server to access generated charts in Jupyter notebooks:

```shell
$ cd notebooks
$ jupyter-notebook
```

Follow the instructions on the console to access the notebook from the browser.

Alternatively extract the images to the `images` directory by running:

```shell
$ make notebook
$ make generate_charts
```

## EVM engine versions
Expand Down
Loading

0 comments on commit d766b04

Please sign in to comment.