Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: removed broken nfc code #61

Merged
merged 4 commits into from
Oct 22, 2024
Merged

fix!: removed broken nfc code #61

merged 4 commits into from
Oct 22, 2024

Conversation

mhochsto
Copy link
Contributor

@mhochsto mhochsto commented Oct 22, 2024

we temporarily removed Nfc functionality in AabrevvaSDK and had to remove it here too. Will come back in the future.

0x7061
0x7061 previously approved these changes Oct 22, 2024
@axi92 axi92 changed the title fix: removed nfc fix!: removed nfc Oct 22, 2024
@axi92 axi92 changed the title fix!: removed nfc fix!: removed broken nfc code Oct 22, 2024
Copy link
Member

@axi92 axi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still traces of NFC in the files:
android/src/main/AndroidManifest.xml
example/ios/ExampleAppExample/Info.plist

axi92
axi92 previously approved these changes Oct 22, 2024
0x7061
0x7061 previously approved these changes Oct 22, 2024
@mhochsto mhochsto dismissed stale reviews from 0x7061 and axi92 via 82e3d6d October 22, 2024 13:11
@0x7061 0x7061 merged commit 0e3ee40 into main Oct 22, 2024
10 checks passed
@0x7061 0x7061 deleted the fix/remove-nfc branch October 22, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants