Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved eslint config to package.json #25

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

mhochsto
Copy link
Contributor

No description provided.

@mhochsto mhochsto requested review from axi92 and 0x7061 August 14, 2024 10:50
@axi92
Copy link
Member

axi92 commented Aug 14, 2024

I just checked the docs and although it is working we should not use eslint 8.x because its EOL is in October. https://eslint.org/version-support/

We should upgrade eslint to 9.x and try then the config from the docs.
Would you please apply those changes and see if it still works? @mhochsto

PS: I also merged the changes from main so its up to date =)

axi92
axi92 previously approved these changes Aug 14, 2024
@0x7061
Copy link
Member

0x7061 commented Aug 16, 2024

Due to incompatibilities with our current eslint plugin infrastructure, we should stick to [email protected] for the time being.
@axi92 @mhochsto

@axi92
Copy link
Member

axi92 commented Aug 16, 2024

Due to incompatibilities with our current eslint plugin infrastructure, we should stick to [email protected] for the time being. @axi92 @mhochsto

Thanks for checking!👍

@axi92 axi92 merged commit ffade7c into main Aug 16, 2024
7 checks passed
@axi92 axi92 deleted the chore/Separate-eslint-conf-from-package-json branch August 16, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants