Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix percent condition evaluation #8

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Fix percent condition evaluation #8

merged 2 commits into from
Mar 13, 2024

Conversation

dobrovolsky
Copy link
Contributor

Percentage condition doesn't work due to error

TypeError: '<' not supported between instances of 'int' and 'str'

@n4mespace
Copy link
Collaborator

awesome) also, can you add some test case pls :)

here:

featureflags-py/featureflags_client/tests/http/test_conditions.py

Line 84 in e25d010

def test_percent():

@n4mespace n4mespace merged commit 1d414a0 into evo-company:main Mar 13, 2024
4 checks passed
@dobrovolsky dobrovolsky deleted the patch-1 branch March 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dobrovolsky @n4mespace