feat: add HasTypeIDWithAmount interface #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warlof
reviewed
Apr 2, 2024
Remove redundant extends Co-authored-by: Loïc Leuilliot <[email protected]>
Crypta-Eve
added a commit
to eveseat-plugins/seat-fitting
that referenced
this pull request
Apr 3, 2024
seat-inventory needs to update some stuff when a fitting changes. I tried to use an observer for this, but: The plugin first saves the fitting and only afterwards save the items of the fit, meaning the observer fires before the items of a fitting have been saved. This PR adds a laravel event that fires after a fitting has been saved. The same has been done with doctrines for the same reason. This PR depends on eveseat/services#180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new interface between HasTypeID and IPriceable. The issue is that sometimes, you have a list of items with amount, like a asset list, that doesn't need the price side from IPriceable, but that could profit of the amount side of IPriceable.
I'm currently working on making seat-inventory compatible with the new item ecosystem around the prices plugin and would massively profit of this new interface.