fix(role): update creation doc and validation rules

eveseat · Dec 30, 2020 · 4d8d91e · 4d8d91e
1 parent 11c2abc
commit 4d8d91e
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/Http/Controllers/Api/v2/RoleController.php b/src/Http/Controllers/Api/v2/RoleController.php
@@ -151,6 +151,15 @@ public function getDetail(int $role_id)
      *                      type="string",
      *                      format="byte",
      *                      description="Base64 encoded new role logo"
+     *                  ),
+     *                  @OA\Property(
+     *                      property="permissions",
+     *                      description="A list of the permissions which have to be attached to the role.",
+     *                      type="array",
+     *                      @OA\Items(
+     *                          type="string",
+     *                          description="A permission name"
+     *                      )
      *                  )
      *              )
      *          )

diff --git a/src/Http/Validation/NewRole.php b/src/Http/Validation/NewRole.php
@@ -23,6 +23,7 @@
 namespace Seat\Api\Http\Validation;
 
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Validation\Rule;
 
 /**
  * Class NewRole.
@@ -53,8 +54,23 @@ public function rules()
         return [
             'title' => 'string|unique:roles,title|required',
             'description' => 'string',
-            'permissions' => 'array',
+            'permissions' => [
+                'array',
+                Rule::in($this->getPermissionsList()),
+            ],
             'logo' => 'base64image',
         ];
     }
+
+    /**
+     * @return array
+     */
+    private function getPermissionsList(): array
+    {
+        return collect(config('seat.permissions'))->map(function ($permissions, $scope) {
+            return collect(array_keys($permissions))->transform(function ($permission) use ($scope) {
+                return $scope . '.' . $permission;
+            });
+        })->flatten()->all();
+    }
 }