[Feat] #8569 Tag Type #8720
[Feat] #8569 Tag Type #8720
Conversation
WalkthroughThis pull request introduces comprehensive support for tag types across the Gauzy application. The changes span multiple files and modules, adding functionality to create, manage, and filter tags based on their types. The implementation includes updates to services, components, data transfer objects (DTOs), and localization files to support a new tag type selection feature. The modifications enhance the tagging system by allowing more granular organization and categorization of tags. Changes
Possibly related PRs
Suggested reviewers
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
View your CI Pipeline Execution ↗ for commit 5b8b22d.
☁️ Nx Cloud last updated this comment at |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15092885 | Triggered | Generic High Entropy Secret | 46c62c2 | packages/core/src/lib/tenant-api-key/tenant-api-key.service.ts | View secret |
| 15092886 | Triggered | Generic High Entropy Secret | 46c62c2 | packages/core/src/lib/tenant-api-key/tenant-api-key.service.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (8)
packages/contracts/src/lib/tag.model.ts (1)
61-64: Consider adding validation constraintsWhile the interface is well-structured, consider adding validation constraints for the
typeproperty (e.g., min/max length, allowed characters) to ensure data consistency.packages/ui-core/core/src/lib/services/tag-type/tag-types.service.ts (1)
23-29: Consider adding retry logic for network resilience.The HTTP calls could benefit from retry logic to handle temporary network failures.
getTagTypes(where: ITagTypesFindInput, relations: string[] = []): Promise<IPagination<ITagType>> { return firstValueFrom( this.http.get<IPagination<ITagType>>(`${TagTypesService.API_URL}`, { params: toParams({ where, relations }) - }) + }).pipe( + retry(3), + catchError((error) => { + console.error('Error fetching tag types:', error); + throw error; + }) + ) ); }packages/ui-core/shared/src/lib/tags/tags-mutation.component.ts (2)
49-53: Fix typo in getter documentation.The documentation for the color getter contains a typo: "Getter fr or color" should be "Getter for color".
161-162: Simplify boolean expression.The ternary operation for isTenantLevel can be simplified.
-isTenantLevel: organizationId ? false : true, +isTenantLevel: !organizationId,🧰 Tools
🪛 Biome (1.9.4)
[error] 161-161: Unnecessary use of boolean literals in conditional expression.
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with(lint/complexity/noUselessTernary)
packages/core/src/lib/tag-type/tag-type.seed.ts (2)
90-91: Enhance warning message with more context.The warning message could provide more context about the impact of skipping the tenant.
-console.warn(`No organizations found for tenant ID: ${tenant.id}`); +console.warn(`Skipping tag type creation for tenant ID: ${tenant.id} - No associated organizations found. This may impact tag type availability for this tenant.`);
109-111: Consider batch processing for large datasets.For large datasets, consider implementing batch processing to avoid memory issues.
-return await dataSource.manager.save(tagTypes); +const BATCH_SIZE = 1000; +const results: TagType[] = []; + +for (let i = 0; i < tagTypes.length; i += BATCH_SIZE) { + const batch = tagTypes.slice(i, i + BATCH_SIZE); + const savedBatch = await dataSource.manager.save(batch); + results.push(...savedBatch); +} + +return results;packages/core/src/lib/tags/tag.service.ts (1)
Line range hint
167-169: Enhance error logging structure.Consider using a structured logging approach for better error tracking.
-console.log('Error while getting tags', error); +console.error({ + message: 'Error while getting tags', + error: error.message, + stack: error.stack, + context: 'TagService.findTags' +});apps/gauzy/src/app/pages/tags/tags.component.ts (1)
238-243: Consider adjusting column widths for better layout.The new tagTypeName column takes up 20% width, which might make the description column too narrow at 70%. Consider adjusting the widths for better content display.
- width: '20%', + width: '15%',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (31)
.env.local(2 hunks)apps/gauzy/src/app/pages/tags/tags.component.html(1 hunks)apps/gauzy/src/app/pages/tags/tags.component.ts(7 hunks)packages/contracts/src/lib/tag.model.ts(2 hunks)packages/core/src/lib/app/app.module.ts(2 hunks)packages/core/src/lib/core/seeds/seed-data.service.ts(3 hunks)packages/core/src/lib/tag-type/tag-type.controller.ts(1 hunks)packages/core/src/lib/tag-type/tag-type.seed.ts(1 hunks)packages/core/src/lib/tags/commands/tag.list.command.ts(1 hunks)packages/core/src/lib/tags/dto/create-tag.dto.ts(1 hunks)packages/core/src/lib/tags/dto/update-tag.dto.ts(1 hunks)packages/core/src/lib/tags/tag.service.ts(4 hunks)packages/ui-core/core/src/lib/services/index.ts(1 hunks)packages/ui-core/core/src/lib/services/tag-type/index.ts(1 hunks)packages/ui-core/core/src/lib/services/tag-type/tag-types.service.ts(1 hunks)packages/ui-core/i18n/assets/i18n/ach.json(1 hunks)packages/ui-core/i18n/assets/i18n/ar.json(1 hunks)packages/ui-core/i18n/assets/i18n/bg.json(1 hunks)packages/ui-core/i18n/assets/i18n/de.json(1 hunks)packages/ui-core/i18n/assets/i18n/en.json(1 hunks)packages/ui-core/i18n/assets/i18n/es.json(1 hunks)packages/ui-core/i18n/assets/i18n/fr.json(1 hunks)packages/ui-core/i18n/assets/i18n/he.json(1 hunks)packages/ui-core/i18n/assets/i18n/it.json(1 hunks)packages/ui-core/i18n/assets/i18n/nl.json(1 hunks)packages/ui-core/i18n/assets/i18n/pl.json(1 hunks)packages/ui-core/i18n/assets/i18n/pt.json(1 hunks)packages/ui-core/i18n/assets/i18n/ru.json(1 hunks)packages/ui-core/i18n/assets/i18n/zh.json(1 hunks)packages/ui-core/shared/src/lib/tags/tags-mutation.component.html(3 hunks)packages/ui-core/shared/src/lib/tags/tags-mutation.component.ts(6 hunks)
✅ Files skipped from review due to trivial changes (4)
- packages/core/src/lib/tag-type/tag-type.controller.ts
- packages/core/src/lib/tags/commands/tag.list.command.ts
- packages/ui-core/core/src/lib/services/tag-type/index.ts
- packages/ui-core/i18n/assets/i18n/en.json
🧰 Additional context used
🪛 Biome (1.9.4)
packages/ui-core/shared/src/lib/tags/tags-mutation.component.ts
[error] 161-161: Unnecessary use of boolean literals in conditional expression.
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with
(lint/complexity/noUselessTernary)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: test
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build
🔇 Additional comments (32)
packages/core/src/lib/tags/dto/create-tag.dto.ts (1)
6-11: LGTM! Verify tag type relation handlingThe addition of
tagTypeIdto the DTO is well-structured and maintains type safety.Let's verify the tag type relation handling in the codebase:
✅ Verification successful
Tag type relation handling verified successfully
The codebase shows proper implementation of tag type relations across all layers - from database entities through services to UI components.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if tagType relation is properly handled in tag-related operations rg -g '!*.{spec,test}.ts' -A 5 'tagType[^a-zA-Z]' packages/Length of output: 6202
packages/core/src/lib/tags/dto/update-tag.dto.ts (1)
6-13: LGTM! Consistent with CreateTagDTOThe UpdateTagDTO properly mirrors the CreateTagDTO changes while maintaining partial update capability through PartialType.
packages/contracts/src/lib/tag.model.ts (1)
28-32: LGTM! Clean formatting improvementThe interface formatting enhances readability while maintaining functionality.
packages/ui-core/core/src/lib/services/index.ts (1)
60-60: LGTM! Verify tag-type module exportsThe export is properly placed and follows the established pattern.
Let's verify the tag-type module exports:
✅ Verification successful
✓ Tag-type module exports verified successfully
The TagTypesService is properly implemented and exported through the module's barrel files, following Angular's best practices.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check tag-type module structure and exports rg -g '!*.{spec,test}.ts' -l "export.*class.*TagType" packages/ui-core/core/src/lib/services/tag-type/Length of output: 173
Script:
#!/bin/bash # Check the implementation and exports of tag-types.service.ts cat packages/ui-core/core/src/lib/services/tag-type/tag-types.service.ts # Check if there are any other exports in the module rg -g '!*.{spec,test}.ts' "export" packages/ui-core/core/src/lib/services/tag-type/Length of output: 2458
packages/ui-core/core/src/lib/services/tag-type/tag-types.service.ts (1)
1-14: LGTM! Well-structured service implementation.The service is properly implemented with dependency injection and extends the CrudService base class.
packages/core/src/lib/tags/tag.service.ts (1)
67-67: Consider adding index hints for query optimization.The query involves multiple joins and group by operations. Consider adding index hints for better performance.
Let's verify the existing indexes:
Also applies to: 152-152
apps/gauzy/src/app/pages/tags/tags.component.ts (4)
9-11: LGTM! Dependencies are properly imported.The imports are correctly organized and include all necessary dependencies for tag type functionality.
38-38: LGTM! Service and property are properly initialized.The TagTypesService is correctly injected and the tagTypes property is properly typed as ITagType[].
Also applies to: 48-48
290-318: LGTM! Error handling is properly implemented.The getTagTypes method includes:
- Proper loading state management
- Error handling with user feedback
- Correct use of tenant and organization context
327-333: LGTM! Tag type relation is properly included.The getTags method correctly includes the tagType relation in the query.
packages/core/src/lib/app/app.module.ts (1)
161-161: LGTM! Module is properly imported and registered.The TagTypeModule is correctly imported and added to the imports array in the correct alphabetical order.
Also applies to: 393-393
packages/core/src/lib/core/seeds/seed-data.service.ts (3)
213-213: LGTM! Seed functions are properly imported.The tag type seed functions are correctly imported.
578-579: LGTM! Default tag types are seeded in correct order.The createTagTypes function is called after createDefaultTags, maintaining proper data dependency order.
1011-1015: LGTM! Random tag types are seeded in correct order.The createRandomOrganizationTagTypes function is called after createRandomOrganizationTags, maintaining consistency with the default seeding order.
packages/ui-core/shared/src/lib/tags/tags-mutation.component.html (3)
7-7: LGTM! Translation pipes are properly formatted.The translation pipes are formatted consistently and improve code readability.
Also applies to: 23-23
77-95: LGTM! Tag type selection is properly implemented.The tag type selection field:
- Follows the same structure as other form fields
- Uses nb-select component correctly
- Includes proper translations and bindings
99-104: LGTM! Form actions are properly formatted.The form action buttons are formatted consistently and maintain proper spacing.
apps/gauzy/src/app/pages/tags/tags.component.html (1)
14-14: LGTM! Improved property namingChanged from
option.propertytooption.valuewhich is a more semantic and conventional property name for filter options..env.local (1)
59-59: Verify database migration from SQLite to PostgreSQLThe database type has been changed from SQLite to PostgreSQL. Ensure that:
- All required PostgreSQL dependencies are installed
- Database migration scripts are in place
- Application code is compatible with PostgreSQL
✅ Verification successful
PostgreSQL migration is fully supported
The codebase has built-in support for PostgreSQL migrations through TypeORM. The migration system includes:
- Dedicated PostgreSQL-specific migration methods
- Database type detection and routing
- Automatic query adaptation for PostgreSQL syntax
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for PostgreSQL dependencies in package.json rg "pg|postgres|typeorm.*postgres" package.json # Look for migration scripts fd -e ts -e js migrationLength of output: 460
Script:
#!/bin/bash # Check all database-related dependencies cat package.json # Check database configuration setup fd -e ts -e js database config rg -A 5 "createConnection|DataSource" # Check database type support in migration files rg -l "type.*=.*('|\").*sql"Length of output: 65767
Script:
#!/bin/bash # Check TypeORM configuration and database setup rg -A 5 "TypeOrmModule|createConnection|DataSource" packages/core/src/ rg -A 5 "type.*=.*('|\").*sql" packages/core/src/ # Check migration files content cat packages/core/src/lib/database/migrations/1705138670108-MysqlTablesMigration.tsLength of output: 66382
Script:
#!/bin/bash # Check database configuration cat packages/config/src/config/database.config.ts cat packages/core/src/lib/database/database.module.ts # Check database type support in migration files cat packages/core/src/lib/database/migration-executor.tsLength of output: 15217
packages/ui-core/i18n/assets/i18n/zh.json (1)
2360-2361: LGTM! Added Chinese translations for tag type featureAdded proper Chinese translations for:
- "TAGS_TYPE": "标签类型"
- "TAGS_SELECT_TYPE": "选择标签类型"
The translations are well-structured and consistent with the tag type feature changes.
packages/ui-core/i18n/assets/i18n/ar.json (1)
2358-2359: LGTM! The new tag type translations are properly implemented.The added Arabic translations for tag type selection are grammatically correct and consistent with the UI terminology used throughout the application.
Let's verify the translations are consistent across language files:
✅ Verification successful
Arabic translations are properly implemented and consistent
The Arabic translations for both "TAGS_TYPE" and "TAGS_SELECT_TYPE" are grammatically correct and properly formatted. While checking other language files, I noticed some incomplete translations in Acholi, Bulgarian, and Hebrew files, but that's outside the scope of this review.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify tag type translations exist in all language files # Expected: Should find TAGS_SELECT_TYPE key in all language files rg -l "TAGS_SELECT_TYPE" packages/ui-core/i18n/assets/i18n/*.jsonLength of output: 1202
Script:
#!/bin/bash # Description: Check the actual translations for TAGS_SELECT_TYPE and TAGS_TYPE # Expected: Should show the translations in all files for file in packages/ui-core/i18n/assets/i18n/*.json; do echo "=== $(basename "$file") ===" rg -A1 '"TAGS_SELECT_TYPE":|"TAGS_TYPE":' "$file" doneLength of output: 4406
packages/ui-core/i18n/assets/i18n/he.json (1)
2385-2387: LGTM! The Hebrew translations for tag type functionality look good.The new translations are properly formatted and accurately convey the intended meaning in Hebrew.
packages/ui-core/i18n/assets/i18n/ru.json (1)
2391-2392: LGTM! The Russian translations for tag type functionality are accurate.The added translations are grammatically correct and properly convey the meaning of "Tag Type" and "Select tag type" in Russian.
packages/ui-core/i18n/assets/i18n/bg.json (1)
2419-2420: LGTM! The Bulgarian translation for tag type selection looks good.The added translation follows the correct format and provides an appropriate Bulgarian translation for the tag type selection functionality.
packages/ui-core/i18n/assets/i18n/nl.json (2)
2360-2361: LGTM! The Dutch translation for tag type selection looks accurate.The translation "TAGS_TYPE": "Tagstype" and "TAGS_SELECT_TYPE": "Selecteer tagtype" are grammatically correct and consistent with Dutch language conventions. The translations properly convey the meaning of selecting a tag type.
Line range hint
1-2362: The overall translation file structure and formatting is clean and well-organized.The translations are properly nested in logical sections, follow consistent formatting, and maintain proper JSON structure throughout the file.
packages/ui-core/i18n/assets/i18n/pl.json (1)
2360-2361: LGTM! Well-structured translations addedThe new Polish translations for tag types are accurate and follow the existing format:
- "TAGS_TYPE": "Typy tagów" (Tag types)
- "TAGS_SELECT_TYPE": "Wybierz typ tagu" (Select tag type)
packages/ui-core/i18n/assets/i18n/it.json (1)
2360-2361: LGTM! The new tag type translations are well-formatted.The added Italian translations for tag type functionality are accurate and consistent with the application's localization style:
- "TAGS_TYPE": "Tipo di tag" (Tag Type)
- "TAGS_SELECT_TYPE": "Seleziona il tipo di tag" (Select tag type)
packages/ui-core/i18n/assets/i18n/pt.json (1)
2360-2361: LGTM! Well-implemented translationsThe Portuguese translations for tag types are grammatically correct and maintain consistency with both the English versions and the rest of the translation file.
packages/ui-core/i18n/assets/i18n/es.json (1)
2362-2363: LGTM! The Spanish translations for tag type selection look good.The added translations are properly formatted, grammatically correct in Spanish, and accurately convey the meaning for tag type selection functionality:
- "TAGS_TYPE": "Tipo de etiquetas" (Tag types)
- "TAGS_SELECT_TYPE": "Seleccionar tipo de etiqueta" (Select tag type)
packages/ui-core/i18n/assets/i18n/fr.json (1)
2361-2362: LGTM! The new tag type selection translation looks good.The French translation for tag type selection is grammatically correct and properly integrated into the TAGS_PAGE section.
packages/ui-core/i18n/assets/i18n/de.json (1)
2356-2357: LGTM! The German translations for tag types look good.The added translations are properly formatted and provide appropriate German text for the tag type selection functionality.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/gauzy/src/app/pages/tags/tags.component.ts (2)
290-316: Use translation key for error message.The
getTagTypesimplementation looks good, but the error message should use a translation key instead of a hardcoded string.- this.toastrService.danger('TAGS_PAGE.TAGS_FETCH_FAILED', 'Error fetching tag types'); + this.toastrService.danger('TAGS_PAGE.TAGS_FETCH_FAILED', 'TAGS_PAGE.ERROR.FETCH_TAG_TYPES');
370-382: Improve filtering logic readability and performance.Consider these improvements to the filtering logic:
- Use a more semantic check for "all" tags
- Use Array.prototype.filter with early return for better performance
selectedFilterOption(value: string) { - if (value === '') { + const SHOW_ALL_TAGS = ''; + if (value === SHOW_ALL_TAGS) { this._isFiltered = false; this._refresh$.next(true); this.tags$.next(true); return; } - if (value) { - const tags = this.allTags.filter((tag) => tag.tagTypeId === value); - this._isFiltered = true; - this._refresh$.next(true); - this.smartTableSource.load(tags); - this.tags$.next(true); - } + const tags = this.allTags.filter((tag) => tag.tagTypeId === value); + this._isFiltered = true; + this._refresh$.next(true); + this.smartTableSource.load(tags); + this.tags$.next(true); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/gauzy/src/app/pages/tags/tags.component.ts(7 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build
- GitHub Check: test
🔇 Additional comments (4)
apps/gauzy/src/app/pages/tags/tags.component.ts (4)
9-11: LGTM! Clean import organization and proper typing.The new imports and the
tagTypesproperty are well-organized and properly typed to support the tag type functionality.Also applies to: 38-38
48-48: LGTM! Proper dependency injection.The
TagTypesServiceis correctly injected following Angular's dependency injection best practices.
66-66: LGTM! Proper initialization sequence.The
getTagTypes()call is correctly integrated into the initialization chain, maintaining a logical order of operations.
325-331: LGTM! Proper eager loading of tag type relation.The
getTagsmethod correctly includes the tag type relation in the query.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
apps/gauzy/src/app/pages/tags/tags.component.ts (4)
66-66: Consider optimizing the initialization sequence.The current implementation calls
getTagTypes()aftergetTags()in the initialization pipeline. Consider fetching tag types before tags to ensure filter options are available when tags are loaded.this.tags$ .pipe( debounceTime(300), tap(() => (this.loading = true)), - tap(() => this.getTags()), tap(() => this.getTagTypes()), + tap(() => this.getTags()), tap(() => this.clearItem()), untilDestroyed(this) ) .subscribe();
290-316: Enhance type safety in getTagTypes method.While the implementation is good, consider these improvements for better type safety:
- Type the response from getTagTypes service call
- Add interface for filter option structure
interface IFilterOption { value: string; displayName: string; } // Use in filterOptions property filterOptions: IFilterOption[] = [];
320-331: Consider caching tag type relation data.The implementation correctly fetches tags with their tag types, but consider caching the relation data to improve performance, especially for larger datasets.
370-382: Enhance filter option robustness.Consider these improvements to the filtering logic:
- Add type guard for tag type ID
- Handle case when tag type doesn't exist
selectedFilterOption(value: string) { if (value === '') { this._isFiltered = false; this._refresh$.next(true); this.tags$.next(true); return; } if (value) { + const tagType = this.tagTypes.find(type => type.id === value); + if (!tagType) { + this.toastrService.warning('Invalid tag type selected'); + return; + } const tags = this.allTags.filter((tag) => tag.tagTypeId === value); this._isFiltered = true; this._refresh$.next(true); this.smartTableSource.load(tags); this.tags$.next(true); } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/gauzy/src/app/pages/tags/tags.component.ts(7 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: test
- GitHub Check: build
🔇 Additional comments (3)
apps/gauzy/src/app/pages/tags/tags.component.ts (3)
9-11: LGTM! Clean import and property declarations.The new imports and property declaration for tag types are well-organized and properly typed.
Also applies to: 38-38
48-48: LGTM! Proper dependency injection.The TagTypesService is correctly injected following Angular's dependency injection pattern.
238-243: Add value preparation for tag type column.The tag type column needs value preparation to handle null/undefined cases and proper translation.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
apps/gauzy/src/app/pages/tags/tags.component.ts (2)
290-316: Enhance error handling and type safety.The tag type fetching implementation is good but could be improved:
- The API response type should be explicitly defined
- The filterOptions array should be cleaned up in the error case
Consider this enhancement:
+ interface TagTypeResponse { + items: ITagType[]; + total: number; + } async getTagTypes() { this.loading = true; const { tenantId } = this.store.user; const { id: organizationId } = this.organization; try { - const { items } = await this.tagTypesService.getTagTypes({ + const { items } = await this.tagTypesService.getTagTypes<TagTypeResponse>({ tenantId, organizationId }); this.tagTypes = items; this.filterOptions.push( ...this.tagTypes.map((tagType) => ({ value: tagType.id, displayName: tagType.type })) ); this.loading = false; } catch (error) { this.loading = false; + this.filterOptions = [{ value: '', displayName: 'All' }]; this.toastrService.danger('TAGS_PAGE.TAGS_FETCH_FAILED', 'Error fetching tag types'); } }
369-382: Improve type safety and maintainability of filter logic.The filter implementation could be enhanced with better type safety and maintainability.
Consider these improvements:
+ const ALL_TAGS_FILTER = ''; + type FilterValue = string; - selectedFilterOption(value: string) { + selectedFilterOption(value: FilterValue) { - if (value === '') { + if (value === ALL_TAGS_FILTER) { this._isFiltered = false; this._refresh$.next(true); this.tags$.next(true); return; } if (value) { const tags = this.allTags.filter((tag) => tag.tagTypeId === value); this._isFiltered = true; this._refresh$.next(true); this.smartTableSource.load(tags); this.tags$.next(true); } }packages/core/src/lib/core/seeds/seed-data.service.ts (1)
1016-1020: Document seeding order dependency.While the implementation is correct, it would be helpful to document why tag types are seeded after tags.
Add a comment explaining the seeding order:
+ // Create tag types after tags to maintain proper relationship order await this.tryExecute( 'Random Organization Tag Types', createRandomOrganizationTagTypes(this.dataSource, this.randomTenants, this.randomTenantOrganizationsMap) );
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
apps/gauzy/src/app/pages/tags/tags.component.ts(7 hunks)packages/core/src/lib/core/seeds/seed-data.service.ts(3 hunks)packages/ui-core/i18n/assets/i18n/ar.json(1 hunks)packages/ui-core/i18n/assets/i18n/bg.json(1 hunks)packages/ui-core/i18n/assets/i18n/de.json(1 hunks)packages/ui-core/i18n/assets/i18n/en.json(1 hunks)packages/ui-core/i18n/assets/i18n/es.json(1 hunks)packages/ui-core/i18n/assets/i18n/fr.json(1 hunks)packages/ui-core/i18n/assets/i18n/he.json(1 hunks)packages/ui-core/i18n/assets/i18n/it.json(1 hunks)packages/ui-core/i18n/assets/i18n/nl.json(1 hunks)packages/ui-core/i18n/assets/i18n/pl.json(1 hunks)packages/ui-core/i18n/assets/i18n/pt.json(1 hunks)packages/ui-core/i18n/assets/i18n/ru.json(1 hunks)packages/ui-core/i18n/assets/i18n/zh.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (13)
- packages/ui-core/i18n/assets/i18n/es.json
- packages/ui-core/i18n/assets/i18n/nl.json
- packages/ui-core/i18n/assets/i18n/pt.json
- packages/ui-core/i18n/assets/i18n/en.json
- packages/ui-core/i18n/assets/i18n/fr.json
- packages/ui-core/i18n/assets/i18n/it.json
- packages/ui-core/i18n/assets/i18n/pl.json
- packages/ui-core/i18n/assets/i18n/he.json
- packages/ui-core/i18n/assets/i18n/de.json
- packages/ui-core/i18n/assets/i18n/bg.json
- packages/ui-core/i18n/assets/i18n/zh.json
- packages/ui-core/i18n/assets/i18n/ar.json
- packages/ui-core/i18n/assets/i18n/ru.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: test
- GitHub Check: build
🔇 Additional comments (2)
apps/gauzy/src/app/pages/tags/tags.component.ts (1)
9-11: LGTM! Clean import organization.The imports are well-organized and properly scoped, with clear separation between external and internal imports.
packages/core/src/lib/core/seeds/seed-data.service.ts (1)
213-213: LGTM! Proper integration of tag type seeding.The tag type seeding is correctly integrated into the default seeding process, with the import properly placed and the seeding function called after tags are created.
Also applies to: 578-579
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by CodeRabbit
Release Notes: Tag Type Management Enhancement
New Features
Improvements
Technical Enhancements