Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: index reader #7

Merged
merged 6 commits into from
Feb 4, 2024
Merged

feat: index reader #7

merged 6 commits into from
Feb 4, 2024

Conversation

evenyag
Copy link
Owner

@evenyag evenyag commented Feb 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR implements the index reader trait to scan items in the index.

Now the index only supports one shard.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review February 4, 2024 06:19
Copy link
Collaborator

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit dedcc4b into poc/compact-memtable Feb 4, 2024
23 of 24 checks passed
@evenyag evenyag deleted the feat/read-index branch February 4, 2024 06:40
evenyag pushed a commit that referenced this pull request Jul 4, 2024
* catch up changes

Signed-off-by: tison <[email protected]>

* fmt

Signed-off-by: tison <[email protected]>

* Fix cache for 0471 (#7)

* Fix cache for 0471

Signed-off-by: Xuanwo <[email protected]>

* Make clippy happy

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* tidy

Signed-off-by: tison <[email protected]>

* use opendal's exported type

Signed-off-by: tison <[email protected]>

* clippy

Signed-off-by: tison <[email protected]>

* fmt

Signed-off-by: tison <[email protected]>

---------

Signed-off-by: tison <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Co-authored-by: Xuanwo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants