Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read data parts API #13

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

v0y4g3r
Copy link
Collaborator

@v0y4g3r v0y4g3r commented Feb 6, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Read data batches from DataParts.

DataParts contains one active buffer and several frozen parts. Each of these parts returns a DataBatch while read. DataBatch contains a arrow::record_batch::RecordBatch and a hashmap indicates the offset ranges of every primary kety index.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@v0y4g3r v0y4g3r marked this pull request as draft February 6, 2024 12:53
@v0y4g3r v0y4g3r changed the title wip: read data parts feat: read data parts API Feb 6, 2024
@v0y4g3r v0y4g3r marked this pull request as ready for review February 6, 2024 13:07
@v0y4g3r v0y4g3r requested a review from evenyag February 6, 2024 13:08
Copy link
Owner

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy is failed. Not a significant problem.

@v0y4g3r v0y4g3r merged commit dd7b112 into evenyag:poc/compact-memtable Feb 6, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants