Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Discover nav layout #596

Merged

Conversation

ryancormack
Copy link
Contributor

Use domains count, rather than service count when deciding to enable Domains link

Motivation

Fixes #595

Use domains count, rather than service count when deciding to enable Domains link
@ryancormack ryancormack requested a review from boyney123 as a code owner July 16, 2024 14:55
Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: 6ae68f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eventcatalog/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@boyney123 boyney123 merged commit 209e428 into event-catalog:main Jul 17, 2024
2 checks passed
@boyney123
Copy link
Collaborator

@all-contributors add @ryancormack for code

@boyney123
Copy link
Collaborator

Thanks @ryancormack

Copy link
Contributor

@boyney123

I've put up a pull request to add @ryancormack! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domains show as active even if there are no domains
2 participants